-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1950113: manifests: populate aws user tags in infrastructure #4755
Bug 1950113: manifests: populate aws user tags in infrastructure #4755
Conversation
/hold for openshift/api#864 |
|
1e05276
to
9bd866c
Compare
@staebler: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
👀 |
9bd866c
to
4ab07b8
Compare
@staebler: This pull request references Bugzilla bug 1950113, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Bugzilla (pamoedom@redhat.com), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/unhold openshift/api#864 has merged |
498aed1
to
48c4bd7
Compare
Given the amount of validation required in implementation, it could be tricky to get this right. Is user documentation included in a docs PR? LGTM |
after speaking with PX and Docs, because we're using |
/retest |
/skip |
Sounds good. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bump github.com/openshift/api to pick up AWS resource tags in the infrastructure.config.openshift.io CRD. * upgrade kubernetes modules to v0.21.0-rc.0 * pin sigs.k8s.io/controller-runtime to v0.9.0-alpha.1
Add the `platform.aws.experimentalPropagateUserTags` field to the install config. When the field is true, fill out the new `.status.platformStatus.aws.resourceTags` field in the manifest for the infrastructure resource. https://issues.redhat.com/browse/CORS-1657
b6dcb74
to
2033421
Compare
/retest |
/lgtm |
/hold cancel |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@staebler: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@staebler: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged:
These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 1950113 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.7 |
@staebler: #4755 failed to apply on top of branch "release-4.7":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add the
platform.aws.experimentalPropagateUserTags
field to the install config. When the field is true, fill out the newstatus.platformStatus.aws.resourceTags
field in the manifest for the infrastructure resource.openshift/enhancements#706