-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-43655: Update "deprecated API in use" alert expressions for 1.31. #1750
OCPBUGS-43655: Update "deprecated API in use" alert expressions for 1.31. #1750
Conversation
@p0lyn0mial: This pull request explicitly references no jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest-required |
4add543
to
f783d8d
Compare
@@ -34,7 +34,7 @@ spec: | |||
a successful upgrade to the next EUS cluster version with Kubernetes {{ $labels.removed_release }}. | |||
Refer to `oc get apirequestcounts {{ $labels.resource }}.{{ $labels.version }}.{{ $labels.group }} -o yaml` to identify the workload. | |||
expr: >- | |||
group by (group,version,resource,removed_release) (apiserver_requested_deprecated_apis{removed_release=~"1.31"}) | |||
group by (group,version,resource,removed_release) (apiserver_requested_deprecated_apis{removed_release=~"1.3[23]"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sanchezl how do i know what to put here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Even OCP releases (odd Kube releases) are EUS, so next EUS release is +2 minor versions.
- Odd OCP releases (even Kube releases) are not EUS, so next EUS release is +1 minor version.
In this case:
- OCP 4.18 (kube 1.31) is an EUS release so
APIRemovedInNextEUSReleaseInUse
should warn them of APIs removed in the next two releases: OCP 4.19(kube 1.32) and OCP 4.20 (kube 1.33) since it is possible to upgrade "directly" to OCP 4.20 (kube 1.33).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks.
/assign @sanchezl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest-required |
/hold need to check failing |
|
will be unblocked by openshift/library-go#1823 |
/hold cancel |
@p0lyn0mial: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: p0lyn0mial, sanchezl, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
66b7caf
into
openshift:master
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-kube-apiserver-operator |
@p0lyn0mial: Jira Issue OCPBUGS-43655 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
No description provided.