Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-43655: Update "deprecated API in use" alert expressions for 1.31. #1750

Merged
merged 3 commits into from
Oct 18, 2024
Merged

OCPBUGS-43655: Update "deprecated API in use" alert expressions for 1.31. #1750

merged 3 commits into from
Oct 18, 2024

Conversation

p0lyn0mial
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 7, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request explicitly references no jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@p0lyn0mial
Copy link
Contributor Author

/retest-required

p0lyn0mial
p0lyn0mial commented Oct 7, 2024
View reviewed changes
bindata/assets/alerts/api-usage.yaml
@@ -34,7 +34,7 @@ spec:
a successful upgrade to the next EUS cluster version with Kubernetes {{ $labels.removed_release }}.
Refer to `oc get apirequestcounts {{ $labels.resource }}.{{ $labels.version }}.{{ $labels.group }} -o yaml` to identify the workload.
expr: >-
group by (group,version,resource,removed_release) (apiserver_requested_deprecated_apis{removed_release=~"1.31"})
group by (group,version,resource,removed_release) (apiserver_requested_deprecated_apis{removed_release=~"1.3[23]"})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sanchezl how do i know what to put here ?

Copy link
Contributor

@sanchezl sanchezl Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Even OCP releases (odd Kube releases) are EUS, so next EUS release is +2 minor versions.
  • Odd OCP releases (even Kube releases) are not EUS, so next EUS release is +1 minor version.

In this case:

  • OCP 4.18 (kube 1.31) is an EUS release so APIRemovedInNextEUSReleaseInUse should warn them of APIs removed in the next two releases: OCP 4.19(kube 1.32) and OCP 4.20 (kube 1.33) since it is possible to upgrade "directly" to OCP 4.20 (kube 1.33).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.

@p0lyn0mial
Copy link
Contributor Author

/assign @sanchezl

sanchezl
sanchezl approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sanchezl
Copy link
Contributor

sanchezl commented Oct 7, 2024

/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 3a58fd7 and 2 for PR HEAD f783d8d in total

@p0lyn0mial
Copy link
Contributor Author

/hold

need to check failing ci/prow/e2e-aws-ovn-upgrade

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 7, 2024
@p0lyn0mial p0lyn0mial mentioned this pull request Oct 8, 2024
Merged
@p0lyn0mial
Copy link
Contributor Author

p0lyn0mial commented Oct 8, 2024 •
edited
Loading

ci/prow/e2e-aws-ovn-upgrade is permanently broken on openshift/library-go#1575 (comment)

{Failed to upgrade kube-apiserver, operator was degraded (KubeAPIServerStaticResources_SyncError): KubeAPIServerStaticResourcesDegraded: "assets/alerts/api-usage.yaml" (string): prometheusrules.monitoring.coreos.com "api-usage" is invalid: metadata.resourceVersion: Invalid value: 0x0: must be specified for an update
KubeAPIServerStaticResourcesDegraded:   }

@p0lyn0mial
Copy link
Contributor Author

will be unblocked by openshift/library-go#1823

@p0lyn0mial p0lyn0mial mentioned this pull request Oct 15, 2024
Closed
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 17, 2024
@p0lyn0mial
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2024
@p0lyn0mial p0lyn0mial mentioned this pull request Oct 17, 2024
Closed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-disruptive-single-node b96d9c5 link false /test e2e-aws-operator-disruptive-single-node
ci/prow/e2e-gcp-operator-single-node b96d9c5 link false /test e2e-gcp-operator-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

vrutkovs
vrutkovs approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 18, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, sanchezl, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [p0lyn0mial,sanchezl,vrutkovs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 66b7caf into openshift:master Oct 18, 2024
13 of 15 checks passed
@p0lyn0mial
Copy link
Contributor Author

xref: openshift/library-go#1819

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-apiserver-operator
This PR has been included in build ose-cluster-kube-apiserver-operator-container-v4.18.0-202410181110.p0.g66b7caf.assembly.stream.el9.
All builds following this will include this PR.

@p0lyn0mial p0lyn0mial changed the title NO-JIRA: Update "deprecated API in use" alert expressions for 1.31. OCPBUGS-43655: Update "deprecated API in use" alert expressions for 1.31. Oct 22, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: Jira Issue OCPBUGS-43655 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrutkovs vrutkovs vrutkovs approved these changes

@sanchezl sanchezl sanchezl approved these changes

@dinhxuanvu dinhxuanvu Awaiting requested review from dinhxuanvu

Assignees

@vrutkovs vrutkovs

@sanchezl sanchezl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@p0lyn0mial @openshift-ci-robot @sanchezl @openshift-bot @vrutkovs