Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-43655: audit: do not log requests to /livez #1819

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

p0lyn0mial
Copy link
Contributor

@p0lyn0mial p0lyn0mial commented Oct 7, 2024

when we switched the API servers to use the /livez EP we forgot to update the audit policy.
this pr updates the base policy which stops logging request to the mentioned ep.

kudos to @deads2k for discovering this.

proof pr at openshift/cluster-kube-apiserver-operator#1751

@openshift-ci openshift-ci bot requested review from deads2k and tkashem October 7, 2024 07:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

@p0lyn0mial: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@vrutkovs vrutkovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 7, 2024
Copy link
Contributor

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 45b605e into openshift:master Oct 7, 2024
4 checks passed
@p0lyn0mial p0lyn0mial changed the title audit: do not log requests to /livez OCPBUGS-43655: audit: do not log requests to /livez Oct 22, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: Jira Issue OCPBUGS-43655: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43655 has been moved to the MODIFIED state.

In response to this:

when we switched the API servers to use the /livez EP we forgot to update the audit policy.
this pr updates the base policy which stops logging request to the mentioned ep.

kudos to @deads2k for discovering this.

proof pr at openshift/cluster-kube-apiserver-operator#1751

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@p0lyn0mial
Copy link
Contributor Author

/cherrypick release-4.17

@openshift-cherrypick-robot

@p0lyn0mial: new pull request created: #1847

In response to this:

/cherrypick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wangke19
Copy link

/jira refersh

@wangke19
Copy link

/jira refresh

@openshift-ci-robot
Copy link

@wangke19: Jira Issue OCPBUGS-43655: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-43655 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants