Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config #698

openshift-bot · 2020-09-17T00:03:02Z

This PR is autogenerated by the ocp-build-data-enforcer.
It updates the base images in the Dockerfile used for promotion in order to ensure it
matches the configuration in the ocp-build-data repository used
for producing release artifacts.

Instead of merging this PR you can also create an alternate PR that includes the changes found here.

If you believe the content of this PR is incorrect, please contact the dptp team in
#aos-art.

This PR is autogenerated by the [ocp-build-data-enforcer][1]. It updates the base images in the Dockerfile used for promotion in order to ensure it matches the configuration in the [ocp-build-data repository][2] used for producing release artifacts. Instead of merging this PR you can also create an alternate PR that includes the changes found here. If you believe the content of this PR is incorrect, please contact the dptp team in #aos-art. [1]: https://github.com/openshift/ci-tools/tree/master/cmd/ocp-build-data-enforcer [2]: https://github.com/openshift/ocp-build-data/tree/openshift-4.6/images

openshift-ci-robot · 2020-09-17T00:03:08Z

@openshift-bot: This pull request references Bugzilla bug 1878163, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

periklis · 2020-09-17T07:17:13Z

/assign @periklis

periklis · 2020-09-17T07:53:20Z

Dockerfile

@@ -19,7 +19,7 @@ RUN make build

 FROM registry.svc.ci.openshift.org/ocp/4.6:cli as origincli

-FROM registry.svc.ci.openshift.org/ocp/4.6:base-8
+FROM registry.svc.ci.openshift.org/ocp/4.6:base


Need to test this localy first. This may block local builds.

periklis · 2020-09-17T07:53:29Z

/hold

periklis · 2020-09-17T08:06:10Z

As expected the switch back to:

FROM registry.svc.ci.openshift.org/ocp/4.6:base

breaks local builds.

@jupierce Can we enforce to use here FROM registry.svc.ci.openshift.org/ocp/4.6:base-8 somehow w/o the bot overriding this directive all the time?

vimalk78 · 2020-09-17T11:21:52Z

/retest

yselkowitz · 2020-09-17T22:02:45Z

/retest

periklis · 2020-09-18T07:06:11Z

Hey folks, Can we stop putting retest until this PR is adapted to fix our local builds?

jupierce · 2020-09-21T17:38:39Z

@periklis 4.6:base is now based on rhel-8. I'm not sure why this would break local builds. Will reach out in slack.

periklis · 2020-09-22T07:29:17Z

@periklis 4.6:base is now based on rhel-8. I'm not sure why this would break local builds. Will reach out in slack.

I am not sure if we still use up2date repos to install openssl and rsync on this container, but resolving the dependencies fails in the end due to python:

           Requires: librpmbuild.so.3()(64bit)                                                                                                                                                 
           Removing: rpm-build-libs-4.11.3-43.el7.x86_64 (@anaconda/7.8)                                                                                                                       
               librpmbuild.so.3()(64bit)                                                       
           Updated By: rpm-build-libs-4.14.2-37.el8.x86_64 (xyz5)
              ~librpmbuild.so.8()(64bit)                                                       
Error: Package: rpm-python-4.11.3-43.el7.x86_64 (@anaconda/7.8)
           Requires: librpmsign.so.1()(64bit)                                                                                                                                                             Removing: rpm-build-libs-4.11.3-43.el7.x86_64 (@anaconda/7.8)       
               librpmsign.so.1()(64bit) 
           Updated By: rpm-build-libs-4.14.2-37.el8.x86_64 (xyz5)
              ~librpmsign.so.8()(64bit)                                                                                                                                                        
Error: Package: rpm-python-4.11.3-43.el7.x86_64 (@anaconda/7.8)
           Requires: librpm.so.3()(64bit)
           Removing: rpm-libs-4.11.3-43.el7.x86_64 (@anaconda/7.8)
               librpm.so.3()(64bit)
           Updated By: rpm-libs-4.14.2-37.el8.x86_64 (xyz5)
              ~librpm.so.8()(64bit)
Error: Package: python-libs-2.7.5-88.el7.x86_64 (@anaconda/7.8)
           Requires: libreadline.so.6()(64bit)
           Removing: readline-6.2-11.el7.x86_64 (@anaconda/7.8)
               libreadline.so.6()(64bit)
           Updated By: readline-7.0-10.el8.x86_64 (xyz5)
              ~libreadline.so.7()(64bit)
Error: Package: rpm-python-4.11.3-43.el7.x86_64 (@anaconda/7.8)
           Requires: librpmio.so.3()(64bit)
           Removing: rpm-libs-4.11.3-43.el7.x86_64 (@anaconda/7.8)
               librpmio.so.3()(64bit)
           Updated By: rpm-libs-4.14.2-37.el8.x86_64 (xyz5)
              ~librpmio.so.8()(64bit)
Error: Package: rpm-python-4.11.3-43.el7.x86_64 (@anaconda/7.8)
           Requires: liblua-5.1.so()(64bit)
           Removing: lua-5.1.4-15.el7.x86_64 (@anaconda/7.8)
               liblua-5.1.so()(64bit)
           Updated By: lua-5.3.4-11.el8.x86_64 (xyz)
               Not found
Error: Package: rpm-python-4.11.3-43.el7.x86_64 (@anaconda/7.8)
....

jcantrill · 2020-09-22T17:39:35Z

/retest

jcantrill · 2020-09-22T18:42:12Z

/retest

jcantrill · 2020-09-22T18:42:29Z

/approve
/lgtm

jcantrill · 2020-09-22T18:42:40Z

/hold cancel

openshift-ci-robot · 2020-09-22T18:42:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcantrill, openshift-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcantrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-09-22T21:30:56Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-22T21:50:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-22T23:26:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-09-22T23:52:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-09-23T03:30:16Z

@openshift-bot: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

openshift/cluster-resource-override-admission-operator#37 is open

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1878163 has not been moved to the MODIFIED state.

In response to this:

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

periklis · 2020-09-23T07:23:33Z

For the record, we need to pull the base image locally once again before starting the build:

podman pull registry.svc.ci.openshift.org/ocp/4.6:base

…le-baseimages-to-mach-ocp-build-data-config Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Sep 17, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 17, 2020

openshift-ci-robot requested review from alanconway and periklis September 17, 2020 00:03

openshift-ci-robot assigned periklis Sep 17, 2020

periklis reviewed Sep 17, 2020

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 17, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2020

openshift-ci-robot assigned jcantrill Sep 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 22, 2020

openshift-merge-robot merged commit 54a1aeb into openshift:master Sep 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config #698

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config #698

openshift-bot commented Sep 17, 2020

openshift-ci-robot commented Sep 17, 2020

periklis commented Sep 17, 2020

periklis Sep 17, 2020

periklis commented Sep 17, 2020

periklis commented Sep 17, 2020 •

edited

Loading

vimalk78 commented Sep 17, 2020

yselkowitz commented Sep 17, 2020

periklis commented Sep 18, 2020

jupierce commented Sep 21, 2020

periklis commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 23, 2020

periklis commented Sep 23, 2020

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config #698

Bug 1878163: Updating Dockerfile baseimages to mach ocp-build-data config #698

Conversation

openshift-bot commented Sep 17, 2020

openshift-ci-robot commented Sep 17, 2020

periklis commented Sep 17, 2020

periklis Sep 17, 2020

Choose a reason for hiding this comment

periklis commented Sep 17, 2020

periklis commented Sep 17, 2020 • edited Loading

vimalk78 commented Sep 17, 2020

yselkowitz commented Sep 17, 2020

periklis commented Sep 18, 2020

jupierce commented Sep 21, 2020

periklis commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

jcantrill commented Sep 22, 2020

openshift-ci-robot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-bot commented Sep 22, 2020

openshift-ci-robot commented Sep 23, 2020

periklis commented Sep 23, 2020

periklis commented Sep 17, 2020 •

edited

Loading