Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1878163: Dockerfile.rhel: Bump to Go 1.15 #457

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Bug 1878163: Dockerfile.rhel: Bump to Go 1.15 #457

merged 1 commit into from
Sep 17, 2020

Conversation

wking
Copy link
Member

@wking wking commented Sep 17, 2020

ART is waffling around the 1.14 <-> 1.15 transition, but we don't need to wait. Let the future start today!

Replaces #456, but without the commit message to mach typo or the bogus link to an ocp-build-data branch where the CVO is currently reverted back to Go 1.14.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: This pull request references Bugzilla bug 1878163, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1878163: Dockerfile.rhel: Bump to Go 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2020
@wking
Dockerfile.rhel: Bump to Go 1.15
1d9a319 
ART is waffling around the 1.14 <-> 1.15 transition [1], but we don't
need to wait.  Let the future start today!

[1]: openshift-eng/ocp-build-data#665
LalatenduMohanty
LalatenduMohanty approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@LalatenduMohanty LalatenduMohanty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LalatenduMohanty, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [LalatenduMohanty,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LalatenduMohanty
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 02467f9 into openshift:master Sep 17, 2020
@openshift-ci-robot
Copy link
Contributor

@wking: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1878163 has not been moved to the MODIFIED state.

In response to this:

Bug 1878163: Dockerfile.rhel: Bump to Go 1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the go-1.15 branch September 17, 2020 22:14
This was referenced Sep 21, 2020
Merged
Merged
Merged
Merged
wking added a commit to wking/cluster-version-operator that referenced this pull request Sep 29, 2020
@wking
*: Move to klog v2
ea6ca01 
When we moved to 0.19 Kube tooling in ef236c3 (vendor: Bump
client-go and library-go to current 4.6 tips 2020-07-24, openshift#420), the
tooling moved to klog v2.  Port our local klog consumers so we don't
have to worry about configuring multiple klogs [1].

Generated with:

  $ sed -i 's|^go 1.13|go 1.15|' go.mod
  $ sed -i 's|k8s.io/klog v1.0.0|k8s.io/klog/v2 v2.3.0|' go.mod
  $ sed -i 's|"k8s.io/klog"|"k8s.io/klog/v2"|' $(git grep -l k8s.io/klog cmd lib pkg)
  $ sed -i 's/klog.V(\([0-9]\)) /klog.V(\1).Enabled() /' $(git grep -l klog.V cmd lib pkg)
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.15.2 linux/amd64

The change to Go 1.15 catches us up with 1d9a319 (Dockerfile.rhel:
Bump to Go 1.15, 2020-09-16, openshift#457).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1883705
@wking wking mentioned this pull request Sep 29, 2020
Merged
wking added a commit to wking/cluster-version-operator that referenced this pull request Sep 29, 2020
@wking
*: Move to klog v2
24a0f5b 
When we moved to 0.19 Kube tooling in ef236c3 (vendor: Bump
client-go and library-go to current 4.6 tips 2020-07-24, openshift#420), the
tooling moved to klog v2.  Port our local klog consumers so we don't
have to worry about configuring multiple klogs [1].

Generated with:

  $ sed -i 's|^go 1.13|go 1.15|' go.mod
  $ sed -i 's|k8s.io/klog v1.0.0|k8s.io/klog/v2 v2.3.0|' go.mod
  $ sed -i 's|"k8s.io/klog"|"k8s.io/klog/v2"|' $(git grep -l k8s.io/klog cmd lib pkg)
  $ sed -i 's|klog.V(\([0-9]\)) |klog.V(\1).Enabled() |' $(git grep -l klog.V cmd lib pkg)
  $ go mod tidy
  $ go mod vendor
  $ git add -A go.* vendor

using:

  $ go version
  go version go1.15.2 linux/amd64

The change to Go 1.15 catches us up with 1d9a319 (Dockerfile.rhel:
Bump to Go 1.15, 2020-09-16, openshift#457).

[1]: https://bugzilla.redhat.com/show_bug.cgi?id=1883705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LalatenduMohanty LalatenduMohanty LalatenduMohanty approved these changes

@vrutkovs vrutkovs Awaiting requested review from vrutkovs

Assignees

@LalatenduMohanty LalatenduMohanty

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wking @openshift-ci-robot @LalatenduMohanty @openshift-bot @openshift-merge-robot