OCPBUGS-12856: Support Device Plugin Resources For Smart NIC and DPU Hosts by wizhaoredhat · Pull Request #1721 · openshift/cluster-network-operator

wizhaoredhat · 2023-02-27T23:00:20Z

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster.

The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K.

An additional daemonset is rendered if there is Smart NIC nodes in the cluster similarly with the DPU Host nodes.

wizhaoredhat · 2023-02-27T23:01:25Z

@zshi-redhat @bn222 PTAL.

pkg/network/ovn_kubernetes.go

zshi-redhat · 2023-03-14T05:12:49Z

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster.

The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K.

The resource name is mandatory field for DPU Host node/mode, but not Smart NIC node/mode, right?

hack/dpu-mode.yaml

bindata/network/ovn-kubernetes/managed/ovnkube-node.yaml

zshi-redhat · 2023-03-14T05:13:27Z

/cc @jcaamano

zshi-redhat · 2023-03-14T05:13:38Z

/cc @pliurh

wizhaoredhat · 2023-03-14T16:15:17Z

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster.
The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K.

The resource name is mandatory field for DPU Host node/mode, but not Smart NIC node/mode, right?

Yes there is a check in OVN-K

wizhaoredhat · 2023-03-31T03:48:46Z

@jcaamano @zshi-redhat @pliurh PTAL.

jcaamano · 2023-04-20T13:31:03Z

/approve
/lgtm

jcaamano · 2023-04-20T13:33:05Z

/hold

until we can merge stuff on 4.14

flavio-fernandes

/lgtm

bindata/network/ovn-kubernetes/managed/ovnkube-node.yaml

bindata/network/ovn-kubernetes/self-hosted/ovnkube-node.yaml

pkg/network/ovn_kubernetes.go

openshift-ci-robot · 2023-04-27T14:01:52Z

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-12856, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster.

The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K.

An additional daemonset is rendered if there is Smart NIC nodes in the cluster similarly with the DPU Host nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wizhaoredhat · 2023-04-27T14:03:27Z

/jira refresh

openshift-ci-robot · 2023-04-27T14:03:34Z

@wizhaoredhat: This pull request references Jira Issue OCPBUGS-12856, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.14.0) matches configured target version for branch (4.14.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster. The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K. An additional daemonset is rendered if there is Smart NIC nodes in the cluster similarly with the DPU Host nodes. Signed-off-by: William Zhao <wizhao@redhat.com>

flavio-fernandes

/lgtm

openshift-ci · 2023-04-27T14:26:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flavio-fernandes, jcaamano, wizhaoredhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

flavio-fernandes · 2023-04-27T18:28:24Z

/retest-required

wizhaoredhat · 2023-04-28T14:57:20Z

/retest

jcaamano · 2023-05-05T16:43:12Z

/hold cancel

openshift-ci-robot · 2023-05-05T18:45:24Z

/retest-required

Remaining retests: 0 against base HEAD 0a4d1fa and 2 for PR HEAD 0bb035e in total

wizhaoredhat · 2023-05-05T20:39:10Z

/retest-required

openshift-ci · 2023-05-06T02:15:15Z

@wizhaoredhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2023-05-06T02:19:53Z

@wizhaoredhat: Jira Issue OCPBUGS-12856: All pull requests linked via external trackers have merged:

openshift/cluster-network-operator#1721

Jira Issue OCPBUGS-12856 has been moved to the MODIFIED state.

Details

In response to this:

Removed the NodeMode from the dpu-mode config map. This was done because the design has changed from using a cluster wide node mode to using node labels to identify Full, DPU Host, DPU, and Smart NIC nodes in the cluster.

The node labels can be overridden from the default values by using the config map. The resource-name is mandatory field of the config map and is needed for DPU Host and Smart NIC nodes to support the management port feature in OVN-K.

An additional daemonset is rendered if there is Smart NIC nodes in the cluster similarly with the DPU Host nodes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2023

openshift-ci bot requested review from abhat and dcbw February 27, 2023 23:00

wizhaoredhat commented Feb 27, 2023

View reviewed changes

pkg/network/ovn_kubernetes.go Outdated Show resolved Hide resolved

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch 3 times, most recently from 6201164 to 48b46ea Compare March 6, 2023 23:26

wizhaoredhat changed the title ~~[WIP] Support Device Plugin Resources For Smart NIC and DPU Hosts~~ Support Device Plugin Resources For Smart NIC and DPU Hosts Mar 6, 2023

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2023

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch from 48b46ea to bddde3b Compare March 6, 2023 23:45

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 8, 2023

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch from bddde3b to 386ce79 Compare March 9, 2023 20:40

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2023

zshi-redhat reviewed Mar 14, 2023

View reviewed changes

hack/dpu-mode.yaml Outdated Show resolved Hide resolved

bindata/network/ovn-kubernetes/managed/ovnkube-node.yaml Show resolved Hide resolved

openshift-ci bot requested a review from jcaamano March 14, 2023 05:13

openshift-ci bot requested a review from pliurh March 14, 2023 05:13

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch 2 times, most recently from ac71a2e to 8769e85 Compare March 16, 2023 20:22

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch 2 times, most recently from 33ead79 to b7f34ff Compare March 31, 2023 03:46

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch from b7f34ff to 1c01fb6 Compare April 15, 2023 02:55

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 20, 2023

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2023

flavio-fernandes reviewed Apr 26, 2023

View reviewed changes

openshift-ci bot assigned flavio-fernandes Apr 26, 2023

wizhaoredhat changed the title ~~Support Device Plugin Resources For Smart NIC and DPU Hosts~~ OCPBUGS-12856: Support Device Plugin Resources For Smart NIC and DPU Hosts Apr 27, 2023

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 27, 2023

openshift-ci bot requested a review from anuragthehatter April 27, 2023 14:03

wizhaoredhat force-pushed the support_device_plugin_resources_for_smart_nic_and_dpu branch from 1c01fb6 to 0bb035e Compare April 27, 2023 14:08

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023

flavio-fernandes reviewed Apr 27, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 27, 2023

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023

openshift-merge-robot merged commit 59167ed into openshift:master May 6, 2023

dgoodwin mentioned this pull request May 8, 2023

Revert "OCPBUGS-12856: Support Device Plugin Resources For Smart NIC and DPU Hosts" #1805

Closed

danwinship mentioned this pull request Jan 17, 2024

OCPBUGS-27264: Only reconcile on Node updates with Label changes #2206

Merged

Conversation

wizhaoredhat commented Feb 27, 2023

Uh oh!

wizhaoredhat commented Feb 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

zshi-redhat commented Mar 14, 2023

Uh oh!

Uh oh!

Uh oh!

zshi-redhat commented Mar 14, 2023

Uh oh!

zshi-redhat commented Mar 14, 2023

Uh oh!

wizhaoredhat commented Mar 14, 2023

Uh oh!

wizhaoredhat commented Mar 31, 2023

Uh oh!

jcaamano commented Apr 20, 2023

Uh oh!

jcaamano commented Apr 20, 2023

Uh oh!

flavio-fernandes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 27, 2023

Uh oh!

wizhaoredhat commented Apr 27, 2023

Uh oh!

openshift-ci-robot commented Apr 27, 2023

Uh oh!

flavio-fernandes left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 27, 2023

Uh oh!

flavio-fernandes commented Apr 27, 2023

Uh oh!

wizhaoredhat commented Apr 28, 2023

Uh oh!

jcaamano commented May 5, 2023

Uh oh!

openshift-ci-robot commented May 5, 2023

Uh oh!

wizhaoredhat commented May 5, 2023

Uh oh!

openshift-ci bot commented May 6, 2023

Uh oh!

openshift-ci-robot commented May 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Comments

wizhaoredhat commented Feb 27, 2023 •

edited

Loading