Skip to content

Revert "OCPBUGS-12856: Support Device Plugin Resources For Smart NIC and DPU Hosts"#1805

Closed
dgoodwin wants to merge 1 commit intoopenshift:masterfrom
dgoodwin:revert-1721-support_device_plugin_resources_for_smart_nic_and_dpu
Closed

Revert "OCPBUGS-12856: Support Device Plugin Resources For Smart NIC and DPU Hosts"#1805
dgoodwin wants to merge 1 commit intoopenshift:masterfrom
dgoodwin:revert-1721-support_device_plugin_resources_for_smart_nic_and_dpu

Conversation

@dgoodwin
Copy link
Contributor

@dgoodwin dgoodwin commented May 8, 2023

Reverts #1721

Test revert, something has changed with disruption, we want to see if this is involved.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 8, 2023
@openshift-ci-robot
Copy link
Contributor

@dgoodwin: This pull request references Jira Issue OCPBUGS-12856, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #1721

Test revert, something has changed with disruption, we want to see if this is involved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 8, 2023
@dgoodwin
Copy link
Contributor Author

dgoodwin commented May 8, 2023

/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2fc3c1b0-edc2-11ed-8bcb-35e2887a389c-0

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member

/retest-required

@bertinatto
Copy link
Member

It seems like this reverted solved the problem. Doing another run to have more data for tomorrow.

/payload-aggregate periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade 10

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 8, 2023

@bertinatto: trigger 1 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3073bb80-ede8-11ed-82a5-81fb3313b155-0

@dgoodwin
Copy link
Contributor Author

dgoodwin commented May 9, 2023

I fear this isn't it, our first batch of 10 jobs, only 8 installed, disruption for kube-api was 2 0 6 2 2 7 6 8 for an average of 4.1.
Second batch again only 8 installed, disruption for kube-api was 5 4 10 8 5 5 7 9 for an average of 6.6.

Looking at https://grafana-loki.ci.openshift.org/d/ISnBj4LVk/disruption?from=now-30d&to=now&var-platform=azure&var-percentile=P50&var-backend=kube-api-new-connections&var-releases=4.14&var-from_releases=4.14&var-networks=ovn&var-topologies=ha&var-architectures=amd64&var-min_job_runs=10&orgId=1 our average yesterday was 5.7, so I fear this is probably not our regression. (if there even is a regression)

/close

@openshift-ci openshift-ci bot closed this May 9, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 9, 2023

@dgoodwin: Closed this PR.

Details

In response to this:

I fear this isn't it, our first batch of 10 jobs, only 8 installed, disruption for kube-api was 2 0 6 2 2 7 6 8 for an average of 4.1.
Second batch again only 8 installed, disruption for kube-api was 5 4 10 8 5 5 7 9 for an average of 6.6.

Looking at https://grafana-loki.ci.openshift.org/d/ISnBj4LVk/disruption?from=now-30d&to=now&var-platform=azure&var-percentile=P50&var-backend=kube-api-new-connections&var-releases=4.14&var-from_releases=4.14&var-networks=ovn&var-topologies=ha&var-architectures=amd64&var-min_job_runs=10&orgId=1 our average yesterday was 5.7, so I fear this is probably not our regression. (if there even is a regression)

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@dgoodwin: This pull request references Jira Issue OCPBUGS-12856. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #1721

Test revert, something has changed with disruption, we want to see if this is involved.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments