Skip to content

Conversation

@QiWang19
Copy link
Member

@QiWang19 QiWang19 commented Jun 26, 2025

Add v1 openshift CRD and back to TechpreviewNoUpgrade. It was dropped down to DevP #76 for version migration.
This PR should be merged after


Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384, openshift/origin#29973.

  • Test the cluster can launch with and without specifying techpreview
launch 4.20.0-0.nightly-2025-07-01-051543,https://github.com/openshift/machine-config-operator/pull/5143,https://github.com/openshift/api/pull/2384,https://github.com/openshift/cluster-update-keys/pull/74 aws,techpreview

On the TechPreviewNoUpgrade cluster, the default policy was updated to /etc/containers/policy.json

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@QiWang19
Copy link
Member Author

/test all

@QiWang19 QiWang19 changed the title OpenShift verification uses v1 CRD OCPNODE-3006:OpenShift verification uses v1 CRD Jul 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 8, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 9, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Jul 9, 2025

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2025

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-e2e-aws-upgrade f8b12f1 link true /test okd-e2e-aws-upgrade
ci/prow/okd-e2e-aws f8b12f1 link true /test okd-e2e-aws
ci/prow/okd-images f8b12f1 link true /test okd-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 15, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384, openshift/origin#29973.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 15, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384, openshift/origin#29973.

  • Test the cluster can launch with and without specifying techpreview
launch 4.20.0-0.nightly-2025-07-01-051543,https://github.com/openshift/machine-config-operator/pull/5143,https://github.com/openshift/api/pull/2384,https://github.com/openshift/cluster-update-keys/pull/74 aws,techpreview

On the TechPreviewNoUpgrade cluster, the default policy was updated to /etc/containers/policy.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 16, 2025

@neisw: This PR was included in a payload test run from openshift/origin#29973
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bed3fdc0-6282-11f0-9aa6-3865933ad873-0

QiWang19 added a commit to QiWang19/cluster-update-keys that referenced this pull request Jul 21, 2025
Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1.
Will add openshift policy openshift#74 back after
openshift/api#2384
openshift/mco#5143

Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 29, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

This PR should be merged after


Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384, openshift/origin#29973.

  • Test the cluster can launch with and without specifying techpreview
launch 4.20.0-0.nightly-2025-07-01-051543,https://github.com/openshift/machine-config-operator/pull/5143,https://github.com/openshift/api/pull/2384,https://github.com/openshift/cluster-update-keys/pull/74 aws,techpreview

On the TechPreviewNoUpgrade cluster, the default policy was updated to /etc/containers/policy.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19 QiWang19 changed the title OCPNODE-3006:OpenShift verification uses v1 CRD OCPNODE-3006:OCPBUGS-59860: OpenShift verification uses v1 CRD Jul 29, 2025
Signed-off-by: Qi Wang <qiwan@redhat.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 7, 2025

@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Add v1 openshift CRD and back to TechpreviewNoUpgrade. It was dropped down to DevP #76 for version migration.
This PR should be merged after


Migrate to v1 version of ClusterImagePolicy.
This PR should be merged along with openshift/machine-config-operator#5143, openshift/api#2384, openshift/origin#29973.

  • Test the cluster can launch with and without specifying techpreview
launch 4.20.0-0.nightly-2025-07-01-051543,https://github.com/openshift/machine-config-operator/pull/5143,https://github.com/openshift/api/pull/2384,https://github.com/openshift/cluster-update-keys/pull/74 aws,techpreview

On the TechPreviewNoUpgrade cluster, the default policy was updated to /etc/containers/policy.json

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@QiWang19
Copy link
Member Author

QiWang19 commented Aug 7, 2025

@wking @sdodson PTAL. The prerequisite PRs(slack discussion) are merged and in the latest nightly build. This PR is ready to get in.

@sdodson
Copy link
Member

sdodson commented Aug 8, 2025

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@QiWang19
Copy link
Member Author

QiWang19 commented Aug 8, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 569dfed into openshift:main Aug 8, 2025
6 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-update-keys
This PR has been included in build ose-cluster-update-keys-container-v4.20.0-202508082058.p0.g569dfed.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants