OCPNODE-3006:Migrate ClusterImagePolicy/ImagePolicy to v1 #5143
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-merge-robot
added
the
needs-rebase
QiWang19
changed the title
openshift-merge-robot
removed
the
needs-rebase
|
/test required |
|
@QiWang19: The specified target(s) for The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
/retest-required |
|
/test verify |
|
/test verify |
|
/test verify |
|
/test unit |
|
/retest-required |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
|
/test all |
|
/test all |
|
/test all |
QiWang19
force-pushed
the
v1-imagepolicy
branch
2 times, most recently
from
613f2d2 to
da0f3ce
Compare
QiWang19
changed the title
|
/testwith openshift/machine-config-operator/main/e2e-gcp-op-techpreview openshift/api#2384 openshift/cluster-update-keys#74 #5143 |
|
/testwith openshift/machine-config-operator/main/e2e-aws-ovn openshift/api#2384 openshift/cluster-update-keys#74 #5143 |
|
/testwith openshift/api/master/e2e-aws-ovn-techpreview openshift/api#2384 openshift/cluster-update-keys#74 #5143 |
|
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@neisw: This PR was included in a payload test run from openshift/origin#29973
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/bed3fdc0-6282-11f0-9aa6-3865933ad873-0 |
|
/testwith openshift/origin/main/e2e-gcp-ovn-techpreview-serial openshift/api#2384 openshift/cluster-update-keys#74 openshift/origin#29973 #5143 |
|
@QiWang19, |
|
/testwith openshift/origin/main/e2e-aws-ovn-single-node-techpreview-serial openshift/api#2384 openshift/cluster-update-keys#74 openshift/origin#29973 #5143 |
|
/retest-required |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@yuqi-zhang, could you tag approved? We have put this PR on hold and will proceed after openshift/api#2384 and openshift/cluster-update-keys#76, as discussed. |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
changes seem fine to me
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: QiWang19, saschagrunert, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
openshift-merge-bot
bot
merged commit 00ef469
into
openshift:main
6 participants
- What I did
This PR should be merged after
- How to verify it
Test this PR with openshift/api#2384, openshift/cluster-update-keys#74:
techpreviewOn the TechPreviewNoUpgrade cluster,
openshift-testsOCPFeatureGate:SigstoreImageVerificationtests from OCPNODE-3454: OCPFeatureGate:SigstoreImageVerification update test on v1 (Cluster)ImagePolicy origin#29973 on the clusterhttps://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-machine-config-operator-5143-openshift-api-2384-openshift-cluster-update-keys-74-openshift-origin-29973-openshift-machine-config-operator-5143-e2e-aws-ovn-single-node-techpreview-serial/1943687569761898496
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-machine-config-operator-5143-openshift-api-2384-openshift-cluster-update-keys-74-openshift-machine-config-operator-5143-e2e-gcp-op-techpreview/1943689948745961472
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-machine-config-operator-5143-openshift-api-2384-openshift-cluster-update-keys-74-openshift-machine-config-operator-5143-e2e-aws-ovn/1943691536881422336
https://prow.ci.openshift.org/view/gs/test-platform-results/logs/multi-pr-openshift-machine-config-operator-5143-openshift-api-2384-openshift-cluster-update-keys-74-openshift-machine-config-operator-5143-e2e-aws-ovn-techpreview/1943696710605737984
- Description for the changelog