pkg/cincinnati/cincinnati: Change "installed" -> "reconciling" for VersionNotFound #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
LalatenduMohanty
suggested changes
Aug 3, 2020
|
/hold As I have a review comment. |
openshift-ci-robot
added
the
do-not-merge/hold
…rsionNotFound When you initiate an update from A -> B, if B is not found in the current channel, the cluster would start reporting VersionNotFound after it's first attempt to retrieve recommended updates for B. That usually happens before the update completes, and the old "currently installed version" wasn't a very accurate description of B mid-update. The new wording relaxes our claim about the cluster state (maybe it has been reconciled, maybe not) and just talks about the version we're attempting to reconcile. The addition of "cluster" is intended to be more explicit about which version we are discussing [1]. Personally I think the occurence within the CVO repo's docs and ClusterVersion condition messages is sufficient context, so I'm agnostic about the additional "cluster". [1]: openshift#423 (comment)
wking
force-pushed
the
clarify-currently-installed
branch
from
9f15457
to
ea6899a
Compare
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you initiate an update from A -> B, if B is not found in the current channel, the cluster would start reporting VersionNotFound after it's first attempt to retrieve recommended updates for B. That usually happens before the update completes, and the old "currently installed version" wasn't a very accurate description of B mid-update. The new wording relaxes our claim about the cluster state (maybe it has been reconciled, maybe not) and just talks about the version we're attempting to reconcile.