-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/cincinnati/cincinnati: Change "installed" -> "reconciling" for VersionNotFound #423
pkg/cincinnati/cincinnati: Change "installed" -> "reconciling" for VersionNotFound #423
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold As I have a review comment. |
…rsionNotFound When you initiate an update from A -> B, if B is not found in the current channel, the cluster would start reporting VersionNotFound after it's first attempt to retrieve recommended updates for B. That usually happens before the update completes, and the old "currently installed version" wasn't a very accurate description of B mid-update. The new wording relaxes our claim about the cluster state (maybe it has been reconciled, maybe not) and just talks about the version we're attempting to reconcile. The addition of "cluster" is intended to be more explicit about which version we are discussing [1]. Personally I think the occurence within the CVO repo's docs and ClusterVersion condition messages is sufficient context, so I'm agnostic about the additional "cluster". [1]: openshift#423 (comment)
9f15457
to
ea6899a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, vrutkovs, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
When you initiate an update from A -> B, if B is not found in the current channel, the cluster would start reporting VersionNotFound after it's first attempt to retrieve recommended updates for B. That usually happens before the update completes, and the old "currently installed version" wasn't a very accurate description of B mid-update. The new wording relaxes our claim about the cluster state (maybe it has been reconciled, maybe not) and just talks about the version we're attempting to reconcile.