Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/cincinnati/cincinnati: Change "installed" -> "reconciling" for VersionNotFound #423

Merged

Commits on Aug 4, 2020

  1. pkg/cincinnati/cincinnati: Change "installed" -> "reconciling" for Ve…

    …rsionNotFound
    
    When you initiate an update from A -> B, if B is not found in the
    current channel, the cluster would start reporting VersionNotFound
    after it's first attempt to retrieve recommended updates for B.  That
    usually happens before the update completes, and the old "currently
    installed version" wasn't a very accurate description of B mid-update.
    The new wording relaxes our claim about the cluster state (maybe it
    has been reconciled, maybe not) and just talks about the version we're
    attempting to reconcile.
    
    The addition of "cluster" is intended to be more explicit about which
    version we are discussing [1].  Personally I think the occurence
    within the CVO repo's docs and ClusterVersion condition messages is
    sufficient context, so I'm agnostic about the additional "cluster".
    
    [1]: openshift#423 (comment)
    wking committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    ea6899a View commit details
    Browse the repository at this point in the history