Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31901: Patch PF dynamic module parser to exclude 'next' modules #13832

Merged

Conversation

vojtechszocs
Copy link
Contributor

This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046

  • Ignore dynamic modules nested under deprecated or next directories
  • Add @patternfly/react-table to the list of packages to scan for dynamic modules by default in ConsoleRemotePlugin

Once Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using dist/dynamic-modules.json files provided by these PF packages.

@openshift-ci openshift-ci bot added component/sdk Related to console-plugin-sdk approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 9, 2024
@vojtechszocs vojtechszocs changed the title Patch PF dynamic module parser to exclude 'next' modules OCPBUGS-31901: Patch PF dynamic module parser to exclude 'next' modules May 9, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 9, 2024
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: This pull request references Jira Issue OCPBUGS-31901, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046

  • Ignore dynamic modules nested under deprecated or next directories
  • Add @patternfly/react-table to the list of packages to scan for dynamic modules by default in ConsoleRemotePlugin

Once Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using dist/dynamic-modules.json files provided by these PF packages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 9, 2024
Copy link
Member

@TheRealJon TheRealJon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TheRealJon, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jhadvig
Copy link
Member

jhadvig commented May 13, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 13, 2024
@openshift-ci-robot
Copy link
Contributor

@jhadvig: This pull request references Jira Issue OCPBUGS-31901, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from zhouying7780 May 13, 2024 14:52
@vojtechszocs
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented May 13, 2024

@vojtechszocs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bfee4c6 into openshift:master May 13, 2024
6 checks passed
@openshift-ci-robot
Copy link
Contributor

@vojtechszocs: Jira Issue OCPBUGS-31901: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31901 has been moved to the MODIFIED state.

In response to this:

This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046

  • Ignore dynamic modules nested under deprecated or next directories
  • Add @patternfly/react-table to the list of packages to scan for dynamic modules by default in ConsoleRemotePlugin

Once Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using dist/dynamic-modules.json files provided by these PF packages.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405140243.p0.gbfee4c6.assembly.stream.el9 for distgit openshift-enterprise-console.
All builds following this will include this PR.

@vojtechszocs
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@vojtechszocs: new pull request created: #13849

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/sdk Related to console-plugin-sdk jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants