-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-31901: Patch PF dynamic module parser to exclude 'next' modules #13832
OCPBUGS-31901: Patch PF dynamic module parser to exclude 'next' modules #13832
Conversation
@vojtechszocs: This pull request references Jira Issue OCPBUGS-31901, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: TheRealJon, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/jira refresh |
@jhadvig: This pull request references Jira Issue OCPBUGS-31901, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@vojtechszocs: Jira Issue OCPBUGS-31901: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-31901 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[ART PR BUILD NOTIFIER] This PR has been included in build openshift-enterprise-console-container-v4.17.0-202405140243.p0.gbfee4c6.assembly.stream.el9 for distgit openshift-enterprise-console. |
/cherry-pick release-4.15 |
@vojtechszocs: new pull request created: #13849 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR patches Console PF dynamic module parser for parity with patternfly/patternfly-react/pull/10046
deprecated
ornext
directories@patternfly/react-table
to the list of packages to scan for dynamic modules by default inConsoleRemotePlugin
Once Console bumps PF packages to recent 5.3.x versions (#13770) we will update our dynamic module parser to try using
dist/dynamic-modules.json
files provided by these PF packages.