-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilize dynamic-modules.json provided by PatternFly packages #13866
Utilize dynamic-modules.json provided by PatternFly packages #13866
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vojtechszocs: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
@vojtechszocs this one needs rebase |
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is a follow-up to #13832 and patternfly/patternfly-react/pull/10046
This PR updates
ConsoleRemotePlugin
code to utilizedynamic-modules.json
files provided by relevant PatternFly packages when processing webpack federated shared modules.The current default list of packages eligible for dynamic module processing by
ConsoleRemotePlugin
is following:@patternfly/react-core
@patternfly/react-icons
@patternfly/react-table
When the relevant
dynamic-modules.json
file is missing,ConsoleRemotePlugin
emits an info message to inform developers that it's falling back to Console dynamic module parser (logically equivalent to PatternFly dynamic module parser).How to compare Console dynamic module parser vs.
dynamic-modules.json
files from PatternFly packagespackages/console-dynamic-plugin-sdk/src/webpack/ConsoleRemotePlugin.ts
and put the following code insidesharedDynamicModuleMaps
reducer callback:Rebuild Console plugin SDK and then your plugin, refer to these instructions for details.
This should produce the following files in your plugin directory: