-
Notifications
You must be signed in to change notification settings - Fork 666
OCPBUGS-44059: Run check-resolution in parallel
#14453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-44059: Run check-resolution in parallel
#14453
Conversation
|
@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f6ff629 to
8bebc5b
Compare
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is safe, but wouldn't mind getting @vojtechszocs to look as well
/lgtm
/hold
|
/unhold |
Co-authored-by: Vojtech Szocs <vojtech.szocs@gmail.com>
9eb2ef7 to
ef6c8bd
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logonoff, spadgett, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@logonoff: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@logonoff: Jira Issue OCPBUGS-44059: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-44059 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Fixes:
https://issues.redhat.com/browse/OCPBUGS-44059
Analysis / Root cause:
Currently check-patternfly-modules.sh checks dependencies serially, which could be made faster by checking them in parallel.
Since
yarn whydoes not write to anything, this should be easily parallelizable as there is no race condition with writing back to the yarn.lockSolution Description:
The
check-resolutionfunction is now run in parallelHardware used:
Results after running
time ./check-patternfly-modules.sh:Screen shots / Gifs for design review:
n/a
Unit test coverage report:
n/a
Test setup:
./check-patternfly-modules.shshould run the same as beforeBrowser conformance:
n/a