Skip to content

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Oct 31, 2024

Fixes:

https://issues.redhat.com/browse/OCPBUGS-44059

Analysis / Root cause:

Currently check-patternfly-modules.sh checks dependencies serially, which could be made faster by checking them in parallel.

Since yarn why does not write to anything, this should be easily parallelizable as there is no race condition with writing back to the yarn.lock

Solution Description:

The check-resolution function is now run in parallel

Hardware used:

Fedora Linux 41 (Workstation Edition)
Dell Inc. XPS 13 9310
11th Gen Intel® Core™ i7-1185G7 × 8
32.0 GiB Memory

Results after running time ./check-patternfly-modules.sh:

before (trial 1):
real	3m43.195s
user	4m12.756s
sys	1m23.471s

before (trial 2):
real	3m28.193s
user	4m6.334s
sys	1m17.644s

before (trial 3):
real	3m16.052s
user	3m59.488s
sys	1m16.666s



after (trial 1):
real	2m9.005s
user	5m47.988s
sys	1m38.153s

after (trial 2):
real	1m35.808s
user	5m51.834s
sys	1m46.357s

after (trial 3):
real	1m32.960s
user	5m49.147s
sys	1m42.260s

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

./check-patternfly-modules.sh should run the same as before

Browser conformance:

n/a

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 31, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixes:

https://issues.redhat.com/browse/ODC-XXX
Analysis / Root cause:

Solution Description:

Screen shots / Gifs for design review:

Unit test coverage report:

Test setup:

Browser conformance:

  • Chrome
  • Firefox
  • Safari

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from cajieh and rhamilto October 31, 2024 16:52
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 31, 2024
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-44059

Analysis / Root cause:

Currently check-patternfly-modules.sh checks them serially, which could be improved by checking them in parallel.

Since yarn why does not write to anything, this should be easily parallelizable as there is no race condition with writing back to the yarn.lock

Solution Description:

The check-resolution function is now run in parallel

Hardware used:

Fedora Linux 41 (Workstation Edition)
Dell Inc. XPS 13 9310
11th Gen Intel® Core™ i7-1185G7 × 8
32.0 GiB Memory

Results:

before (trial 1):
real	3m43.195s
user	4m12.756s
sys	1m23.471s

before (trial 2):
real	3m28.193s
user	4m6.334s
sys	1m17.644s

before (trial 3):
real	3m16.052s
user	3m59.488s
sys	1m16.666s



after (trial 1):
real	2m9.005s
user	5m47.988s
sys	1m38.153s

after (trial 2):
real	1m35.808s
user	5m51.834s
sys	1m46.357s

after (trial 3):
real	1m32.960s
user	5m49.147s
sys	1m42.260s

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

./check-patternfly-modules.sh should run the same as before

Browser conformance:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sanketpathak October 31, 2024 17:21
@openshift-ci-robot
Copy link
Contributor

@logonoff: This pull request references Jira Issue OCPBUGS-44059, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

Details

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-44059

Analysis / Root cause:

Currently check-patternfly-modules.sh checks them serially, which could be improved by checking them in parallel.

Since yarn why does not write to anything, this should be easily parallelizable as there is no race condition with writing back to the yarn.lock

Solution Description:

The check-resolution function is now run in parallel

Hardware used:

Fedora Linux 41 (Workstation Edition)
Dell Inc. XPS 13 9310
11th Gen Intel® Core™ i7-1185G7 × 8
32.0 GiB Memory

Results:

before (trial 1):
real	3m43.195s
user	4m12.756s
sys	1m23.471s

before (trial 2):
real	3m28.193s
user	4m6.334s
sys	1m17.644s

before (trial 3):
real	3m16.052s
user	3m59.488s
sys	1m16.666s



after (trial 1):
real	2m9.005s
user	5m47.988s
sys	1m38.153s

after (trial 2):
real	1m35.808s
user	5m51.834s
sys	1m46.357s

after (trial 3):
real	1m32.960s
user	5m49.147s
sys	1m42.260s

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

./check-patternfly-modules.sh should run the same as before

Browser conformance:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the OCPBUGS-44059-parallel-pf-check branch 2 times, most recently from f6ff629 to 8bebc5b Compare November 20, 2024 15:58
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is safe, but wouldn't mind getting @vojtechszocs to look as well

/lgtm
/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 2, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 2, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@logonoff
Copy link
Member Author

logonoff commented Dec 5, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@logonoff logonoff force-pushed the OCPBUGS-44059-parallel-pf-check branch from 9eb2ef7 to ef6c8bd Compare December 5, 2024 18:54
@vojtechszocs
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2024

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6ecdfb9 into openshift:master Dec 6, 2024
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@logonoff: Jira Issue OCPBUGS-44059: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44059 has been moved to the MODIFIED state.

Details

In response to this:

Fixes:

https://issues.redhat.com/browse/OCPBUGS-44059

Analysis / Root cause:

Currently check-patternfly-modules.sh checks dependencies serially, which could be made faster by checking them in parallel.

Since yarn why does not write to anything, this should be easily parallelizable as there is no race condition with writing back to the yarn.lock

Solution Description:

The check-resolution function is now run in parallel

Hardware used:

Fedora Linux 41 (Workstation Edition)
Dell Inc. XPS 13 9310
11th Gen Intel® Core™ i7-1185G7 × 8
32.0 GiB Memory

Results after running time ./check-patternfly-modules.sh:

before (trial 1):
real	3m43.195s
user	4m12.756s
sys	1m23.471s

before (trial 2):
real	3m28.193s
user	4m6.334s
sys	1m17.644s

before (trial 3):
real	3m16.052s
user	3m59.488s
sys	1m16.666s



after (trial 1):
real	2m9.005s
user	5m47.988s
sys	1m38.153s

after (trial 2):
real	1m35.808s
user	5m51.834s
sys	1m46.357s

after (trial 3):
real	1m32.960s
user	5m49.147s
sys	1m42.260s

Screen shots / Gifs for design review:

n/a

Unit test coverage report:

n/a

Test setup:

./check-patternfly-modules.sh should run the same as before

Browser conformance:

n/a

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff deleted the OCPBUGS-44059-parallel-pf-check branch December 6, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants