Skip to content

OCPBUGS-44059: Run check-resolution in parallel #14453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Dec 6, 2024
Merged

OCPBUGS-44059: Run check-resolution in parallel #14453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66f8623
OCPBUGS-44059: Run `check-resolution` in parallel
logonoff Oct 31, 2024
ef6c8bd
Update frontend/scripts/check-patternfly-modules.sh
logonoff Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions frontend/scripts/check-patternfly-modules.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ COL_YELLOW='\033[33m'

resolution_errors=false

# https://docs.ci.openshift.org/docs/architecture/step-registry/#step-execution-environment
OPENSHIFT_CI=${OPENSHIFT_CI:=false}

# Ensure that only one major version resolution exists for the given package in yarn.lock file.
# Having multiple version resolutions may lead to bugs and webpack build or performance issues.
check-resolution() {
Expand Down Expand Up @@ -68,9 +71,18 @@ PKGS_TO_CHECK=(

echo -e "Checking ${COL_YELLOW}yarn.lock${COL_RESET} file for PatternFly module resolutions"

for pkg in "${PKGS_TO_CHECK[@]}"; do
check-resolution "${pkg%%:*}" "${pkg#*:}"
done
if [[ "$OPENSHIFT_CI" == "true" ]]; then
# disable parallel execution in CI to reduce CPU usage
for pkg in "${PKGS_TO_CHECK[@]}"; do
check-resolution "${pkg%%:*}" "${pkg#*:}"
done
else
for pkg in "${PKGS_TO_CHECK[@]}"; do
check-resolution "${pkg%%:*}" "${pkg#*:}" &
done

wait
fi

if [[ "$resolution_errors" == "false" ]]; then
echo -e "${COL_GREEN}No issues detected${COL_RESET}"
Expand Down