Add test against cda cluster to validate sfc behavior #201
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bn222 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test make-e2e-test |
|
Nice! /lgtm |
|
/retest ci/prow/make-fast-e2e-test |
|
@SalDaniele: The
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test ci/prow/make-fast-e2e-test |
|
@SalDaniele: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-merge-robot
added
the
needs-rebase
|
Could you add a README (or a comment somewhere) how such a test can run? Obviously, it depends on the Since the CDA config in Point being: please explain this somewhere (a README would be good). Also, it does seem to me that all those |
openshift-merge-robot
removed
the
needs-rebase
|
/override ci/prow/make-fast-e2e-test |
|
@bn222: Overrode contexts on behalf of bn222: ci/prow/make-fast-e2e-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test remaining-required |
|
/test make-e2e-test |
|
/lgtm |
|
/test make-e2e-test |
openshift-merge-robot
added
the
needs-rebase
3 similar comments
|
/test make-e2e-test |
|
/test make-e2e-test |
4 similar comments
|
/lgtm |
|
/test remaining-required |
Signed-off-by: Salvatore Daniele <sdaniele@redhat.com>
|
/lgtm |
|
/test remaining-required |
3 similar comments
|
@bn222: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| if err != nil { | ||
| return nil, nil, err | ||
| } | ||
| dpuConfig, err := t.createClient("/root/kubeconfig.microshift") |
There was a problem hiding this comment.
The test should run as non-root user. With those paths to the kubeconfig, only root can run them.
I think it should take the files from relativeToAbs("../../kubeconfig.*").
| DpuConfigPath: "hack/cluster-configs/config-dpu.yaml", | ||
| } | ||
| _, dpuConfig, _ := cluster.EnsureExists() | ||
| Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
needs _, dpuConfig, err := ...
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return cfg, nil |
There was a problem hiding this comment.
os.ReadFile() should suffice: https://pkg.go.dev/os#example-ReadFile
| @@ -0,0 +1,136 @@ | |||
| package daemon | |||
| return &pod | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
it seems such utilities should be part of testutils package. Also, why does not not use c.Get()?
| Eventually(func() bool { | ||
| pod := getPod(dpuSideClient, nfName, ns) | ||
| if pod != nil { | ||
| println("Pod got") |
There was a problem hiding this comment.
why does this use println()? Other code seems to use loggers. Also, BeforeSuite() sets up the logger.
No description provided.