update machine-api-usage-telemetry #1072
Conversation
|
superseding #538 |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
During implementation of this enhancement we have determined that there will be a need for two labels on the MachineHealthCheck related metrics. Although these labels have unbounded cardinality, it will only need to be exported through telemetry as a sum without the need for the labels. The alert for machines with old deletion timestamps has been renamed to `MachineNotYetDeleted`, to better describe the root cause as opposed to the symptom.
elmiko
force-pushed
the
update-mao-usage-telemetry
branch
from
1264840
to
994fd70
Compare
|
as per the instructions in the readme, i am overriding the linting job as this is an update to an older enhancement from before the newer template fields. (also, those new fields appear to be the only lint failure) /override ci/prow/markdownlint |
|
/override ci/prow/markdownlint |
|
@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/markdownlint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
openshift-ci
bot
removed
the
lifecycle/stale
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/override ci/prow/markdownlint This is an update to an already merged template, the lint errors are just that it doesn't have some required headings which were added after this original enhancement merged |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/markdownlint In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elmiko: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
During implementation of this enhancement we have determined that there
will be a need for two labels on the MachineHealthCheck related
metrics. Although these labels have unbounded cardinality, it will only
need to be exported through telemetry as a sum without the need for the
labels.
The alert for machines with old deletion timestamps has been renamed to
MachineNotYetDeleted, to better describe the root cause as opposed tothe symptom.