add eus MCO enhancement #771
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rphillips Are we still pursuing this? |
Co-authored-by: Kirsten <kikis.github@gmail.com>
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@sdodson yes. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@rphillips: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| - The MCO will look at all the pools within the cluster, if there are paused | ||
| pools the MCO will make sure the nodes have a n-2 skew. | ||
| - If there is a paused pool with a node skew of greater than n-2, then an | ||
| event will be emitted. |
There was a problem hiding this comment.
Will this block the control plane (master) pool from upgrading or not?
An event seems odd. If the goal is to block, then I think we need to change the MCO to go Upgradable=False so the CVO will refuse upgrades, right?
If the goal is to not block...well, some sort of important/critical alert seems in order, not just an event right?
There was a problem hiding this comment.
If the goal is to block...
The API-server is in charge of blocking; see #762. The MCO is supposed to remind folks that they have old nodes, and provide suggestions about getting them updated. I'd expected that to be via alerts, but I guess spitting out events periodically could accomplish the same thing.
There was a problem hiding this comment.
Looks like implementation is moving forward in openshift/machine-config-operator#2658
I guess the assumption is that we'll follow up with alerts based on the events?
There was a problem hiding this comment.
I think current implementation PR is more generic, it will send event if any node have skew >= 2
|
Inactive enhancement proposals go stale after 28d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale enhancement proposals rot after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Mark the proposal as fresh by commenting If this proposal is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten enhancement proposals close after 7d of inactivity. See https://github.com/openshift/enhancements#life-cycle for details. Reopen the proposal by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.