-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add eus MCO enhancement #771
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,171 @@ | ||
--- | ||
title: eus-upgrades-mco | ||
authors: | ||
- "@rphillips" | ||
reviewers: | ||
- @kikisdeliveryservice | ||
- @yuqi-zhang | ||
approvers: | ||
- "@derekwaynecarr" | ||
- "@crawford" | ||
creation-date: 2021-05-05 | ||
last-updated: 2021-05-05 | ||
status: provisional | ||
see-also: | ||
replaces: | ||
superseded-by: | ||
--- | ||
|
||
# EUS Upgrades MCO | ||
|
||
## Release Signoff Checklist | ||
|
||
- [ ] Enhancement is `implementable` | ||
- [ ] Design details are appropriately documented from clear requirements | ||
- [ ] Test plan is defined | ||
- [ ] Operational readiness criteria is defined | ||
- [ ] Graduation criteria for dev preview, tech preview, GA | ||
- [ ] User-facing documentation is created in [openshift-docs](https://github.com/openshift/openshift-docs/) | ||
- [x] [Enhancement 762](https://github.com/openshift/enhancements/pull/762) | ||
|
||
|
||
## Summary | ||
|
||
This enhancement outlines the Machine Config Operator (MCO) behavior when | ||
propogating Kubernetes Events in EUS upgrade scenarios. The MCO will emit | ||
events that are user readable and be clear enough that a user can take an | ||
action. | ||
|
||
Related to [Enhancement 762](https://github.com/openshift/enhancements/pull/762). | ||
|
||
## Motivation | ||
|
||
The introduction of EUS creates a subset of clusters which we expect will run | ||
4.6 for a year or more then upgrade rapidly, though serially, from 4.6 to 4.10. | ||
This rapid upgrade introduces the risk that those clusters may upgrade faster | ||
than is safe due to constraints imposed by OpenShift, the upstream components of | ||
OpenShift, or deployed workloads. | ||
|
||
This also creates a scenario where admins wish to reduce both the duration and | ||
the disruption to workload associated with the upgrade. | ||
|
||
### Goals | ||
|
||
- The MCO will look at all the pools within the cluster, if there are paused | ||
pools the MCO will make sure the nodes have a n-2 skew. | ||
- If there is a paused pool with a node skew of greater than n-2, then an | ||
event will be emitted. | ||
|
||
### Non-Goals | ||
|
||
### User Stories | ||
|
||
#### Paused Pools | ||
|
||
Modify syncUpgradeableStatus within the MCO to loop through all the pools and | ||
nodes looking for paused pools that are greater than the n-2 skew. | ||
|
||
If a node is found, then emit an event with the message: | ||
|
||
> The $poolName Machine Config Pool does not conform to the n-2 skew. Please | ||
> unpause $poolname to continue upgrades. Unpausing the pool will cause | ||
> disruptions to the workloads. | ||
|
||
### Implementation Details/Notes/Constraints [optional] | ||
|
||
### Risks and Mitigations | ||
|
||
N/A | ||
|
||
## Design Details | ||
|
||
### Open Questions [optional] | ||
|
||
### Test Plan | ||
|
||
- CI tests are necessary which attempt to upgrade while violating kubelet to API | ||
compatibility, ie: 4.6 to 4.7 upgrade with MachineConfigPools paused, then check | ||
for Upgradeable=False condition to be set by the API Server Operator, assuming | ||
that our rules only allow for N-1 skew. | ||
- CI tests will be necessary to verify the events emitted from the MCO | ||
|
||
### Graduation Criteria | ||
|
||
**Note:** *Section not required until targeted at a release.* | ||
|
||
Define graduation milestones. | ||
|
||
These may be defined in terms of API maturity, or as something else. Initial proposal | ||
should keep this high-level with a focus on what signals will be looked at to | ||
determine graduation. | ||
|
||
Consider the following in developing the graduation criteria for this | ||
enhancement: | ||
|
||
- Maturity levels | ||
- [`alpha`, `beta`, `stable` in upstream Kubernetes][maturity-levels] | ||
- `Dev Preview`, `Tech Preview`, `GA` in OpenShift | ||
- [Deprecation policy][deprecation-policy] | ||
|
||
Clearly define what graduation means by either linking to the [API doc definition](https://kubernetes.io/docs/concepts/overview/kubernetes-api/#api-versioning), | ||
or by redefining what graduation means. | ||
|
||
In general, we try to use the same stages (alpha, beta, GA), regardless how the functionality is accessed. | ||
|
||
[maturity-levels]: https://git.k8s.io/community/contributors/devel/sig-architecture/api_changes.md#alpha-beta-and-stable-versions | ||
[deprecation-policy]: https://kubernetes.io/docs/reference/using-api/deprecation-policy/ | ||
|
||
#### Examples | ||
|
||
These are generalized examples to consider, in addition to the aforementioned [maturity levels][maturity-levels]. | ||
|
||
#### Dev Preview -> Tech Preview | ||
|
||
- Ability to utilize the enhancement end to end | ||
- End user documentation, relative API stability | ||
- Sufficient test coverage | ||
- Gather feedback from users rather than just developers | ||
- Enumerate service level indicators (SLIs), expose SLIs as metrics | ||
- Write symptoms-based alerts for the component(s) | ||
|
||
#### Tech Preview -> GA | ||
|
||
- More testing (upgrade, downgrade, scale) | ||
- Sufficient time for feedback | ||
- Available by default | ||
- Backhaul SLI telemetry | ||
- Document SLOs for the component | ||
- Conduct load testing | ||
|
||
**For non-optional features moving to GA, the graduation criteria must include | ||
end to end tests.** | ||
|
||
#### Removing a deprecated feature | ||
|
||
- Announce deprecation and support policy of the existing feature | ||
- Deprecate the feature | ||
|
||
### Upgrade / Downgrade Strategy | ||
|
||
Despite the topic area, this work does not actually change Upgrade or Downgrade | ||
strategy. | ||
|
||
### Version Skew Strategy | ||
|
||
N/A | ||
|
||
## Implementation History | ||
|
||
[PR](https://github.com/openshift/machine-config-operator/pull/2552) - | ||
@deads2k wrote this as a starting point. The PR can be used as a starting | ||
point, but we need to rewrite it to conform to this document. | ||
|
||
## Drawbacks | ||
|
||
The idea is to find the best form of an argument why this enhancement should _not_ be implemented. | ||
|
||
## Alternatives | ||
|
||
## Infrastructure Needed [optional] | ||
|
||
N/A |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this block the control plane (master) pool from upgrading or not?
An event seems odd. If the goal is to block, then I think we need to change the MCO to go
Upgradable=False
so the CVO will refuse upgrades, right?If the goal is to not block...well, some sort of important/critical alert seems in order, not just an event right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API-server is in charge of blocking; see #762. The MCO is supposed to remind folks that they have old nodes, and provide suggestions about getting them updated. I'd expected that to be via alerts, but I guess spitting out events periodically could accomplish the same thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like implementation is moving forward in openshift/machine-config-operator#2658
I guess the assumption is that we'll follow up with alerts based on the events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think current implementation PR is more generic, it will send event if any node have skew >= 2