Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-5458: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… #175

Merged
merged 1 commit into from
Jan 11, 2023
Merged

OCPBUGS-5458: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… #175

merged 1 commit into from
Jan 11, 2023

Conversation

tjungblu
Copy link

…ord being partially synced to disk

We need to return io.ErrUnexpectedEOF in the error chain, so that etcdserver can repair it automatically.

Backport etcd-io#15068

Signed-off-by: Benjamin Wang wachao@vmware.com

carry of etcd-io#15069

@ahrtr @tjungblu
UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec…
15f68c3 
…ord being partially synced to disk

We need to return io.ErrUnexpectedEOF in the error chain, so that
etcdserver can repair it automatically.

Backport etcd-io#15068

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@tjungblu
Copy link
Author

/cherry-pick openshift-4.12

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 11, 2023
@openshift-cherrypick-robot
Copy link

@tjungblu: once the present PR merges, I will cherry-pick it on top of openshift-4.12 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

@tjungblu: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

OCPBUGS-5458: UPSTREAM:: etcdserver: process the scenaro of the last WAL rec…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@tjungblu: This pull request references Jira Issue OCPBUGS-5458, which is invalid:

  • expected Jira Issue OCPBUGS-5458 to depend on a bug targeting a version in 4.14.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…ord being partially synced to disk

We need to return io.ErrUnexpectedEOF in the error chain, so that etcdserver can repair it automatically.

Backport etcd-io#15068

Signed-off-by: Benjamin Wang wachao@vmware.com

carry of etcd-io#15069

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from deads2k and wking January 11, 2023 10:35
@tjungblu
Copy link
Author

/retest

2 similar comments
@tjungblu
Copy link
Author

/retest

@tjungblu
Copy link
Author

/retest

@dusk125
Copy link

dusk125 commented Jan 11, 2023

/approve

@tjungblu
Copy link
Author

/retest

1 similar comment
@tjungblu
Copy link
Author

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

@tjungblu: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasbro17 hasbro17 added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 11, 2023
@hasbro17
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dusk125, hasbro17, tjungblu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 11, 2023
@openshift-merge-robot openshift-merge-robot merged commit 1878506 into openshift:openshift-4.13 Jan 11, 2023
@openshift-ci-robot
Copy link

@tjungblu: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5458 has been moved to the MODIFIED state.

In response to this:

…ord being partially synced to disk

We need to return io.ErrUnexpectedEOF in the error chain, so that etcdserver can repair it automatically.

Backport etcd-io#15068

Signed-off-by: Benjamin Wang wachao@vmware.com

carry of etcd-io#15069

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 11, 2023
Merged
@openshift-cherrypick-robot
Copy link

@tjungblu: new pull request created: #176

In response to this:

/cherry-pick openshift-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@wking wking Awaiting requested review from wking

Assignees

@hasbro17 hasbro17

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tjungblu @openshift-cherrypick-robot @openshift-ci-robot @dusk125 @hasbro17 @openshift-merge-robot @ahrtr