Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[openshift-4.12] OCPBUGS-5761: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… #176

Merged
merged 1 commit into from
Jan 12, 2023
Merged

[openshift-4.12] OCPBUGS-5761: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… #176

merged 1 commit into from
Jan 12, 2023

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #175

/assign tjungblu

@ahrtr
UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec…
3e579cb 
…ord being partially synced to disk

We need to return io.ErrUnexpectedEOF in the error chain, so that
etcdserver can repair it automatically.

Backport etcd-io#15068

Signed-off-by: Benjamin Wang <wachao@vmware.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 11, 2023
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-5458 has been cloned as Jira Issue OCPBUGS-5761. Retitling PR to link against new bug.
/retitle [openshift-4.12] OCPBUGS-5761: UPSTREAM:: etcdserver: process the scenaro of the last WAL rec…

In response to this:

This is an automated cherry-pick of #175

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [openshift-4.12] OCPBUGS-5458: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… [openshift-4.12] OCPBUGS-5761: UPSTREAM:<carry>: etcdserver: process the scenaro of the last WAL rec… Jan 11, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 11, 2023

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[openshift-4.12] OCPBUGS-5761: UPSTREAM:: etcdserver: process the scenaro of the last WAL rec…

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jan 11, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-5761, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-5458 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-5458 targets the "4.13.0" version, which is one of the valid target versions: 4.13.0
  • bug has dependents

Requesting review from QA contact:
/cc @geliu2016

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #175

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link

/retest

3 similar comments
@tjungblu
Copy link

/retest

@tjungblu
Copy link

/retest

@tjungblu
Copy link

/retest

@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2023

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hasbro17
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasbro17, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2023
@openshift-merge-robot openshift-merge-robot merged commit 978cfef into openshift:openshift-4.12 Jan 12, 2023
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-5761 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #175

/assign tjungblu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tjungblu
Copy link

/cherry-pick openshift-4.11

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 16, 2023
Merged
@openshift-cherrypick-robot
Copy link
Author

@tjungblu: new pull request created: #178

In response to this:

/cherry-pick openshift-4.11

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geliu2016 geliu2016 Awaiting requested review from geliu2016

@Elbehery Elbehery Awaiting requested review from Elbehery

@tjungblu tjungblu Awaiting requested review from tjungblu

Assignees

@hasbro17 hasbro17

@tjungblu tjungblu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @tjungblu @hasbro17 @openshift-merge-robot @ahrtr