Introduce parallelism to unit tests #306
Conversation
openshift-ci-robot
added
the
approved
|
/test e2e |
|
@psimovec or @quarckster please check |
|
/test e2e |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Usage of parallelism seems reasonable to me and LGTM. I have one nitpick unrelated to changes in this PR - about the file you are changing.. pkg/gather/clusterconfig/0_ But as it is unrelated to the changes you made, I let you decide if you want to change it in this PR. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: psimovec, quarckster, rluders The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
This PR implements parallelism to our unit tests to improve its performance.
Categories
Sample archive
No.
Documentation
No.
Unit Tests
pkg/authorizer/clusterauthorizer/clusterauthorizer_test.go- this one can't use parallelismpkg/config/configobserver/configobserver_test.gopkg/controller/status/status_test.gopkg/gather/clusterconfig/0_gahterer_test.gopkg/gather/clusterconfig/certificate_signing_requests_test.gopkg/gather/clusterconfig/config_maps_test.gopkg/gather/clusterconfig/image_pruners_test.gopkg/gather/clusterconfig/image_registries_test.gopkg/gather/clusterconfig/install_plans_test.gopkg/gather/clusterconfig/service_accounts_test.goPrivacy
This PR doesn't collect any data or change any gather.
Changelog
No.
References
https://issues.redhat.com/browse/???
https://bugzilla.redhat.com/show_bug.cgi?id=???
https://access.redhat.com/solutions/???