Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1952906: Add a few tests to configobserver_test.go #409

Merged
merged 3 commits into from
May 7, 2021
Merged

Bug 1952906: Add a few tests to configobserver_test.go #409

merged 3 commits into from
May 7, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Apr 23, 2021

Adds a few extra tests for the configoberver

Categories

  • Bugfix
  • [ ]Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample archive

  • no change

Documentation

  • no change

Unit Tests

  • see pkg/config/configobserver/configobserver_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

References

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2021
@0sewa0 0sewa0 changed the title Add a few tests to configobserver_test.go Bug 1952906: Add a few tests to configobserver_test.go Apr 23, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. label Apr 23, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: This pull request references Bugzilla bug 1952906, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @psimovec

In response to this:

Bug 1952906: Add a few tests to configobserver_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 23, 2021
rluders
rluders suggested changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't const, vars, and structs be defined at the beginning of the file?

@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 28, 2021 •
edited
Loading

the CI fails because of the CI's golang version doesn't match the golang version used for IO and the unit-test I added has a behavior that is different on the two versions. (CI: 1.14 -- go.mod: 1.16) the error has to do with the way an error is converted to string

bump CI golang version: openshift/release#18061 (waiting for this to be merged)

@tremes
Copy link
Contributor

tremes commented May 5, 2021

/retest

@tremes
Copy link
Contributor

tremes commented May 6, 2021

Verified :), reviewed... :)
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

10 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f3ff4b5 into openshift:master May 7, 2021
@openshift-ci
Copy link

openshift-ci bot commented May 7, 2021

@0sewa0: All pull requests linked via external trackers have merged:

Bugzilla bug 1952906 has been moved to the MODIFIED state.

In response to this:

Bug 1952906: Add a few tests to configobserver_test.go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremes tremes tremes left review comments

@rluders rluders rluders requested changes

@mfojtik mfojtik Awaiting requested review from mfojtik

@natiiix natiiix Awaiting requested review from natiiix

@psimovec psimovec Awaiting requested review from psimovec

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@0sewa0 @openshift-ci-robot @tremes @openshift-bot @rluders @openshift-merge-robot