Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

insights-operator: Bump golang version where needed to match go.mod, + cleanup #18061

Merged
merged 1 commit into from
May 4, 2021
Merged

insights-operator: Bump golang version where needed to match go.mod, + cleanup #18061

merged 1 commit into from
May 4, 2021

Conversation

0sewa0
Copy link
Contributor

@0sewa0 0sewa0 commented Apr 26, 2021

Bumps the golang version in build_root to match whats in the insights-operator's go.mod, also removes the unused base_images in tha yamls to make them a bit cleaner.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2021
@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 27, 2021

/retest

1 similar comment
@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 28, 2021

/retest

@0sewa0 0sewa0 mentioned this pull request Apr 28, 2021
Merged
3 tasks
@0sewa0
Copy link
Contributor Author

0sewa0 commented Apr 29, 2021

/retest

2 similar comments
@0sewa0
Copy link
Contributor Author

0sewa0 commented May 3, 2021

/retest

@0sewa0
Copy link
Contributor Author

0sewa0 commented May 4, 2021

/retest

@0sewa0
Copy link
Contributor Author

0sewa0 commented May 4, 2021

/test pj-rehearse

@0sewa0 0sewa0 force-pushed the insigths-operator-golang-version-update branch from 51faf5b to ef595b5 Compare May 4, 2021 11:30
@tremes
Copy link
Contributor

tremes commented May 4, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 4, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0sewa0, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 4, 2021 •
edited
Loading

@0sewa0: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/insights-operator/release-4.6/insights-operator-e2e-tests 51faf5b12c96e836f39c7a916b9752e7a7f674cc link /test pj-rehearse
ci/rehearse/openshift/insights-operator/release-4.7/insights-operator-e2e-tests 51faf5b12c96e836f39c7a916b9752e7a7f674cc link /test pj-rehearse
ci/rehearse/openshift/insights-operator/release-4.7/e2e 51faf5b12c96e836f39c7a916b9752e7a7f674cc link /test pj-rehearse
ci/rehearse/openshift/insights-operator/master/insights-operator-e2e-tests ef595b5 link /test pj-rehearse
ci/rehearse/openshift/insights-operator/release-4.9/e2e ef595b5 link /test pj-rehearse
ci/rehearse/openshift/insights-operator/release-4.8/e2e ef595b5 link /test pj-rehearse
ci/rehearse/openshift/insights-operator/master/e2e ef595b5 link /test pj-rehearse
ci/prow/pj-rehearse ef595b5 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 98e606d into openshift:master May 4, 2021
@openshift-ci-robot
Copy link
Contributor

@0sewa0: Updated the following 3 configmaps:

  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-insights-operator-release-4.9.yaml using file ci-operator/config/openshift/insights-operator/openshift-insights-operator-release-4.9.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-insights-operator-master.yaml using file ci-operator/config/openshift/insights-operator/openshift-insights-operator-master.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-insights-operator-release-4.8.yaml using file ci-operator/config/openshift/insights-operator/openshift-insights-operator-release-4.8.yaml

In response to this:

Bumps the golang version in build_root to match whats in the insights-operator's go.mod, also removes the unused base_images in tha yamls to make them a bit cleaner.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tremes
Copy link
Contributor

tremes commented May 5, 2021

/test release-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Serhii1011010 Serhii1011010 Awaiting requested review from Serhii1011010

@tisnik tisnik Awaiting requested review from tisnik

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0sewa0 @tremes @openshift-ci-robot @openshift-bot @openshift-merge-robot