Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather status of the cephclusters.ceph.rook.io resources #654

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Gather status of the cephclusters.ceph.rook.io resources #654

merged 1 commit into from
Aug 4, 2022

Conversation

tremes
Copy link
Contributor

@tremes tremes commented Jul 19, 2022 •
edited
Loading

This PR adds a new gatherer for gathering status part of the cephclusters.ceph.rook.io resources.

Steps to have some cephcluster resource:

  1. Install ODF via Operator Hub
  2. It requires to create StorageSystem. Create one:
    1. Select Use an existing StorageClass in the first step of Backing storage type
    2. Choose the smallest capacity and select all the nodes in the next step
    3. I've seen error page with 404, but it doesn't matter
  3. oc get cephcluster -A should return something :)

Categories

  • Bugfix
  • Enhancement
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/openshift-storage/ocs-storagecluster-cephcluster.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/ceph_cluster_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-8665
https://issues.redhat.com/browse/INSIGHTOCP-803

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2022
@rluders
Copy link
Contributor

rluders commented Jul 22, 2022

Checked the code and tested it. It worked as expected.
/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@tremes
Copy link
Contributor Author

tremes commented Jul 22, 2022

@rluders Thanks. Unfortunately it needs a rebase. Let me rebaase it

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2022
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2022
rluders
rluders approved these changes Jul 28, 2022
View reviewed changes
Copy link
Contributor

@rluders rluders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2022
@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders, tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Jul 29, 2022
@xJustin
Copy link
Contributor

xJustin commented Jul 29, 2022

/label docs-approved

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 29, 2022
@JoaoFula
Copy link
Contributor

JoaoFula commented Aug 1, 2022

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 1, 2022
@tremes
Copy link
Contributor Author

tremes commented Aug 1, 2022

/test insights-operator-e2e-tests

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 2 against base HEAD 2f490af and 8 for PR HEAD 89f4115 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 1 against base HEAD 2f490af and 7 for PR HEAD 89f4115 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2f490af and 6 for PR HEAD 89f4115 in total

@tremes
Copy link
Contributor Author

tremes commented Aug 2, 2022

/retest

2 similar comments
@tremes
Copy link
Contributor Author

tremes commented Aug 3, 2022

/retest

@JoaoFula
Copy link
Contributor

JoaoFula commented Aug 3, 2022

/retest

@tremes
Copy link
Contributor Author

tremes commented Aug 4, 2022

/test insights-operator-e2e-tests

@openshift-ci
Copy link

openshift-ci bot commented Aug 4, 2022

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 6925a7f into openshift:master Aug 4, 2022
tremes added a commit to tremes/insights-operator that referenced this pull request Aug 5, 2022
@tremes
[release-4.11] Gather status of the cephclusters.ceph.rook.io resourc…
0824abb 
…es (openshift#654)
@tremes tremes mentioned this pull request Aug 5, 2022
Merged
4 tasks
openshift-merge-robot pushed a commit that referenced this pull request Aug 18, 2022
@tremes
[release-4.11] Gather status of the cephclusters.ceph.rook.io resourc…
6a9fd46 
…es (#654) (#655)
This was referenced Aug 18, 2022
Merged
Merged
Merged
@tremes tremes deleted the ceph-cluster-status-data branch July 27, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rluders rluders rluders approved these changes

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@rluders rluders

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tremes @rluders @sferich888 @xJustin @JoaoFula @openshift-ci-robot @openshift-merge-robot