Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-22958: adds cluster storageclasses gather #858

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 2, 2023

This PR implements a new data enhancement to collect StorageClass object from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12013

docs: updated gathered data
@openshift-ci openshift-ci bot requested review from ncaak and tremes November 2, 2023 15:45
Copy link

openshift-ci bot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@rluders rluders requested a review from tremes November 3, 2023 08:37
@rluders rluders force-pushed the feat/gather-storageclass branch from 54a5191 to cc286f6 Compare November 3, 2023 08:41
@rluders rluders force-pushed the feat/gather-storageclass branch 3 times, most recently from 0382e6d to aeca745 Compare November 3, 2023 08:45
@rluders rluders requested a review from tremes November 3, 2023 08:45
@rluders rluders force-pushed the feat/gather-storageclass branch from aeca745 to b79d416 Compare November 3, 2023 08:59
@rluders rluders requested a review from tremes November 3, 2023 08:59
@tremes
Copy link
Contributor

tremes commented Nov 3, 2023

Reviewed and works as expected. @rluders note that you need to provide the JIRA ID (or NO-JIRA) in the PR title.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
Copy link

openshift-ci bot commented Nov 3, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rluders rluders changed the title feat(gather): adds cluster storageclasses gather CCXDEV-12013: adds cluster storageclasses gather Nov 3, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 3, 2023

@rluders: This pull request references CCXDEV-12013 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.15.0" version, but no target version was set.

In response to this:

This PR implements a new data enhancement to collect StorageClass object from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rluders rluders changed the title CCXDEV-12013: adds cluster storageclasses gather OCPBUGS-22958: adds cluster storageclasses gather Nov 6, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 6, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-22958, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @JoaoFula

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR implements a new data enhancement to collect StorageClass object from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula November 6, 2023 09:58
@openshift-ci openshift-ci bot merged commit 2df9754 into openshift:master Nov 6, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: Jira Issue OCPBUGS-22958: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22958 has been moved to the MODIFIED state.

In response to this:

This PR implements a new data enhancement to collect StorageClass object from the cluster.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-12013

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rluders pushed a commit to rluders/insights-operator that referenced this pull request Nov 8, 2023
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
rluders pushed a commit to rluders/insights-operator that referenced this pull request Nov 8, 2023
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
@rluders
Copy link
Contributor Author

rluders commented Nov 14, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@rluders: Jira Issue OCPBUGS-22958 is in an unrecognized state (MODIFIED) and will not be moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-merge-bot bot pushed a commit that referenced this pull request Nov 15, 2023
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
rluders pushed a commit to rluders/insights-operator that referenced this pull request Nov 30, 2023
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
openshift-merge-bot bot pushed a commit that referenced this pull request Dec 6, 2023
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
JoaoFula pushed a commit to JoaoFula/insights-operator that referenced this pull request Jan 23, 2024
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants