Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.14] OCPBUGS-22996: adds cluster storageclasses gather (#858) #865

Merged
merged 1 commit into from
Nov 15, 2023
Merged

[release-4.14] OCPBUGS-22996: adds cluster storageclasses gather (#858) #865

merged 1 commit into from
Nov 15, 2023

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Nov 15, 2023

Backport #858

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-22996

OCPBUGS-22958: adds cluster storageclasses gather (openshift#858)
2768368 
* feat(gather): adds cluster storageclasses

docs: updated gathered data

* refactor: renaming gather after review
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-22996, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Backport #858

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-22996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from ncaak and tremes November 15, 2023 10:06
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@rluders
Copy link
Contributor Author

rluders commented Nov 15, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request references Jira Issue OCPBUGS-22996, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.z) matches configured target version for branch (4.14.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22958 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-22958 targets the "4.15.0" version, which is one of the valid target versions: 4.15.0
  • bug has dependents

Requesting review from QA contact:
/cc @JoaoFula

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from JoaoFula November 15, 2023 10:10
@JoaoFula
Copy link
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 15, 2023
ncaak
ncaak approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ncaak ncaak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rluders
Copy link
Contributor Author

rluders commented Nov 15, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 15, 2023

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rluders
Copy link
Contributor Author

rluders commented Nov 15, 2023

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 15, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit 7f61093 into openshift:release-4.14 Nov 15, 2023
@openshift-ci-robot
Copy link
Contributor

@rluders: Jira Issue OCPBUGS-22996: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-22996 has been moved to the MODIFIED state.

In response to this:

Backport #858

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

  • docs/insights-archive-sample/config/storage/storageclasses/standard-csi.json

Documentation

  • docs/gathered-data.md

Unit Tests

  • pkg/gatherers/clusterconfig/gather_cluster_storageclass_test.go

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/OCPBUGS-22996

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.14.0-202311151632.p0.g7f61093.assembly.stream for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncaak ncaak ncaak approved these changes

@tremes tremes Awaiting requested review from tremes

@JoaoFula JoaoFula Awaiting requested review from JoaoFula

Assignees

@ncaak ncaak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rluders @openshift-ci-robot @JoaoFula @openshift-bot @ncaak