Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: (refactor) job completion uses event instead polling #888

Merged
merged 8 commits into from
Mar 5, 2024
Merged

NO-JIRA: (refactor) job completion uses event instead polling #888

merged 8 commits into from
Mar 5, 2024

Conversation

rluders
Copy link
Contributor

@rluders rluders commented Dec 18, 2023

This PR replaces event polling from periodic job completion and replaces it with event listening.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

N/A

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10669

@openshift-ci openshift-ci bot requested review from rhrmo and tremes December 18, 2023 09:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@rluders
Copy link
Contributor Author

rluders commented Dec 18, 2023

/retest

1 similar comment
@rluders
Copy link
Contributor Author

rluders commented Dec 19, 2023

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncaak, rluders

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tremes
Copy link
Contributor

tremes commented Jan 2, 2024

This is not working as is, because the watch permission (for batch group) is miising for the corresponding role.

@rluders rluders force-pushed the refactor/job-event-listening branch from 20be7ec to 8cbe5b0 Compare February 8, 2024 09:21
@rluders
Copy link
Contributor Author

rluders commented Feb 9, 2024

/retest

1 similar comment
@rluders
Copy link
Contributor Author

rluders commented Feb 10, 2024

/retest

@rluders rluders requested review from tremes and ncaak February 15, 2024 11:09
@tremes
Copy link
Contributor

tremes commented Feb 16, 2024

/test e2e-gcp-ovn-techpreview

@tremes
Copy link
Contributor

tremes commented Feb 19, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2024
@rluders rluders changed the title refactor: job completion uses event instead polling NO-JIRA: (refactor) job completion uses event instead polling Feb 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 19, 2024
@openshift-ci-robot
Copy link
Contributor

@rluders: This pull request explicitly references no jira issue.

In response to this:

This PR replaces event polling from periodic job completion and replaces it with event listening.

Categories

  • Bugfix
  • Data Enhancement
  • Feature
  • Backporting
  • Others (CI, Infrastructure, Documentation)

Sample Archive

N/A

Documentation

N/A

Unit Tests

N/A

Privacy

Yes. There are no sensitive data in the newly collected information.

Changelog

Breaking Changes

No

References

https://issues.redhat.com/browse/CCXDEV-10669

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoaoFula
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 4a8f083 and 2 for PR HEAD 5526179 in total

@JoaoFula
Copy link
Contributor

/retest

@JoaoFula
Copy link
Contributor

@rluders is there a prediction that this PR might affect the time it takes for the Insights ClusterOperator to degrade?
It seems to consistently fail in that step during one test (keeps timing out)

@rluders
Copy link
Contributor Author

rluders commented Feb 22, 2024

@JoaoFula well... it is possible. It isn't pooling anymore to check the status, instead, it is watching the job status to be completed. But, I don't know how it would/could impact the test and cause some timeout. 🤔

@JoaoFula
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8c1273c and 1 for PR HEAD 5526179 in total

@JoaoFula
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD da820b5 and 0 for PR HEAD 5526179 in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 5526179 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 27, 2024
@rluders
Copy link
Contributor Author

rluders commented Feb 28, 2024

/retest

@tremes
Copy link
Contributor

tremes commented Feb 29, 2024

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD da820b5 and 2 for PR HEAD 5526179 in total

@rluders
Copy link
Contributor Author

rluders commented Feb 29, 2024

/retest

@rluders
Copy link
Contributor Author

rluders commented Mar 1, 2024

/test e2e

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8210a45 and 1 for PR HEAD 5526179 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 8adc193 and 0 for PR HEAD 5526179 in total

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 5, 2024

@rluders: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0b8a79c into openshift:master Mar 5, 2024
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-insights-operator-container-v4.16.0-202403052341.p0.g0b8a79c.assembly.stream.el9 for distgit ose-insights-operator.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhrmo rhrmo Awaiting requested review from rhrmo

@tremes tremes Awaiting requested review from tremes

@ncaak ncaak Awaiting requested review from ncaak

Assignees

@tremes tremes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rluders @tremes @openshift-ci-robot @JoaoFula @openshift-bot @ncaak