create: separate bootstrap and node ignition config assets into separate targets #1119

staebler · 2019-01-23T16:37:43Z

The Bootstrap Ignition asset is dependent upon the Master and Worker Ignition assets.
It is problematic to have them all targeted by the same sub-command because it makes
it difficult for a user to modify all of the ignition configs. These changes create
a new sub-command that targets just the Master and Worker Ignition assets.

The ignition-configs sub-command has been renamed to pre-cluster. This reflects that
the sub-command targets more than just the Bootstrap Ignition asset, as it targets
the kubeconfig and the metadata.json as well.

The new sub-command has been named node-config.

Fixes https://jira.coreos.com/browse/CORS-948

For discussion on alternative solutions, see https://docs.google.com/document/d/1Wr82knlY5iY5K10GOBk3Q39HabtuoJcU9pFInSKZclA/edit?usp=sharing.

The openshift-install ignition-configs sub-command has been renamed to pre-cluster. See openshift/installer#1119

docs/user/overview.md

cmd/openshift-install/create.go

crawford · 2019-01-25T20:59:06Z

Can you also re-generate the dependency graph? That will be the ultimate test of whether or not this teases apart the multi-generational relationship.

staebler · 2019-01-25T23:16:31Z

Can you also re-generate the dependency graph? That will be the ultimate test of whether or not this teases apart the multi-generational relationship.

It's already been re-generated.

crawford · 2019-01-25T23:24:05Z

It's already been re-generated.

Oh, GitHub collapsed the diff and I only saw the one commit. Can you split the SVG generation into separate commit as we've done historically?

crawford · 2019-01-25T23:28:12Z

/approve

staebler · 2019-01-26T02:31:12Z

It's already been re-generated.

Oh, GitHub collapsed the diff and I only saw the one commit. Can you split the SVG generation into separate commit as we've done historically?

Sure. I didn't realize that the preference was to separate the SVG generation into a separate commit: I've never separated it in any of my past commits.

openshift-ci-robot · 2019-01-29T19:39:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crawford, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [crawford,staebler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wking · 2019-01-30T05:23:34Z

docs/user/versioning.md

@@ -4,7 +4,8 @@ The installer uses [Semantic Versioning][semver] for its user-facing API.
 Covered by the versioning are:

 * `openshift-install [options] create install-config`, which will always create `install-config.yaml` in the asset directory, although the version of the generated install-config may change.
-* `openshift-install [options] create ignition-configs`, which will always create `bootstrap.ign`, `master.ign`, and `worker.ign` in the asset directory, although the content of the generated files may change.
+* `openshift-install [options] create node-config`, which will always create `master.ign` and `worker.ign` in the asset directory, although the content of the generated files may change.
+* `openshift-install [options] create pre-cluster`, which will always create `bootstrap.ign` in the asset directory, although the content of the generated files may change.


Call out metadata.json here too? auth/kubeconfig? Hive/BYOI will rely on their presence (CC @dgoodwin, @vrutkovs), but they'll be able to adapt to changes. Do we want to make compat commitments for external tooling that consumes them as well? CC @abhinavdahiya, @crawford.

I made the change, but I can take it back out if we decide we do not want to make the compatibility commitment.

wking · 2019-01-30T05:32:16Z

cmd/openshift-install/create.go

+ Use: "node-config",
+ Short: "Generates the ignition configs for the master and worker nodes",
+ },
+ assets: []asset.WritableAsset{&machine.Master{}, &machine.Worker{}},


Actually, who cares about these pointer Ignition configs? Do we even need a target for them? I expect the default pointers will be fine and folks will tweak the machine Ignition configuration by configuring the machine-config server. pre-cluster may be sufficient with it's reduced target set.

I don't know. I thought that @crawford had a use case for modifying the master and worker ignition configs.

staebler · 2019-02-04T16:14:47Z

/retest

staebler · 2019-02-15T19:12:11Z

level=error msg="\t* module.vpc.aws_route_table_association.worker_routing[2]: 1 error occurred:"
level=error msg="\t* aws_route_table_association.worker_routing.2: timeout while waiting for state to become 'success' (timeout: 5m0s)"

/retest

staebler · 2019-02-15T21:00:11Z

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

/retest

staebler · 2019-02-15T22:15:56Z

Flaky tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should expose prometheus metrics for a route [Suite:openshift/conformance/parallel/minimal]
[Conformance][templates] templateinstance impersonation tests should pass impersonation deletion tests [Suite:openshift/conformance/parallel/minimal]
[Feature:Builds][pullsecret][Conformance] docker build using a pull secret Building from a template should create a docker build that pulls using a secret run it [Suite:openshift/conformance/parallel/minimal]
[k8s.io] InitContainer [NodeConformance] should not start app containers if init containers fail on a RestartAlways pod [Conformance] [Suite:openshift/conformance/parallel/minimal] [Suite:k8s]
[k8s.io] Pods should support pod readiness gates [NodeFeature:PodReadinessGate] [Suite:openshift/conformance/parallel] [Suite:k8s]
[k8s.io] Security Context when creating containers with AllowPrivilegeEscalation should allow privilege escalation when not explicitly set and uid != 0 [NodeConformance] [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-apps] Deployment test Deployment ReplicaSet orphaning and adoption regarding controllerRef [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-storage] In-tree Volumes [Driver: hostPathSymlink] [Testpattern: Inline-volume (default fs)] volumes should be mountable [Suite:openshift/conformance/parallel] [Suite:k8s]
[sig-storage] In-tree Volumes [Driver: hostPath] [Testpattern: Inline-volume (default fs)] subPath should support non-existent path [Suite:openshift/conformance/parallel] [Suite:k8s]

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]
[sig-storage] In-tree Volumes [Driver: aws] [Testpattern: Inline-volume (default fs)] subPath should support readOnly directory specified in the volumeMount [Suite:openshift/conformance/parallel] [Suite:k8s]

/retest

staebler · 2019-02-15T23:35:44Z

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

Three times in a row now with this failure. I'll evaluate whether it is a real failure.

staebler · 2019-02-16T00:56:54Z

/retest

staebler · 2019-02-20T15:16:54Z

Failing tests:

[Conformance][Area:Networking][Feature:Router] The HAProxy router should enable openshift-monitoring to pull metrics [Suite:openshift/conformance/parallel/minimal]

/retest

staebler · 2019-02-21T14:07:40Z

/retest

…ate targets The Bootstrap Ignition asset is dependent upon the Master and Worker Ignition assets. It is problematic to have them all targeted by the same sub-command because it makes it difficult for a user to modify all of the ignition configs. These changes create a new sub-command that targets just the Master and Worker Ignition assets. The ignition-configs sub-command has been renamed to pre-cluster. This reflects that the sub-command targets more than just the Bootstrap Ignition asset, as it targets the kubeconfig and the metadata.json as well. The new sub-command has been named node-config. The ignitions-configs sub-command has been deprecated and will be rmeoved once it is no longer used. Fixes https://jira.coreos.com/browse/CORS-948

The ignition-config was split into node-config and pre-cluster targets so the dependency graph needed to be updated. Generated with: $ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg using: $ dot -V dot - graphviz version 2.40.1 (20161225.0304)

openshift-ci-robot · 2019-02-22T21:02:27Z

@staebler: The following test failed for commit 69b980d, say /retest to rerun them:

Test name	Details	Rerun command
ci/prow/e2e-aws	link	`/test e2e-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

staebler · 2019-02-25T20:18:06Z

/hold

Hold for 4.1.

openshift-ci-robot · 2019-03-03T09:09:29Z

@staebler: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

staebler · 2019-04-22T17:15:21Z

/close

Superseded by #1532.

openshift-ci-robot · 2019-04-22T17:15:23Z

@staebler: Closed this PR.

In response to this:

/close

Superseded by #1532.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 23, 2019

openshift-ci-robot requested review from rajatchopra and smarterclayton January 23, 2019 16:38

staebler added a commit to staebler/hive that referenced this pull request Jan 23, 2019

use new name for openshift-install ignition-configs sub-command

4261813

The openshift-install ignition-configs sub-command has been renamed to pre-cluster. See openshift/installer#1119

staebler mentioned this pull request Jan 23, 2019

use new name for openshift-install ignition-configs sub-command openshift/hive#182

Closed

staebler added a commit to staebler/release that referenced this pull request Jan 23, 2019

use new name for openshift-install ignition-configs sub-command

1f88a71

The openshift-install ignition-configs sub-command has been renamed to pre-cluster. See openshift/installer#1119

staebler mentioned this pull request Jan 23, 2019

use new name for openshift-install ignition-configs sub-command openshift/release#2676

Closed

wking reviewed Jan 23, 2019

View reviewed changes

docs/user/overview.md Show resolved Hide resolved

wking reviewed Jan 23, 2019

View reviewed changes

cmd/openshift-install/create.go Outdated Show resolved Hide resolved

wking reviewed Jan 30, 2019

View reviewed changes

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 5, 2019

staebler added 2 commits February 22, 2019 15:13

openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 25, 2019

wking mentioned this pull request Mar 8, 2019

cmd/openshift-install/upi: Add a user-provided-infrastructure subcommand #1393

Merged

wking mentioned this pull request Mar 27, 2019

machines: add the authorized keys for a pool using a machine config #1150

Merged

openshift-ci-robot closed this Apr 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create: separate bootstrap and node ignition config assets into separate targets #1119

create: separate bootstrap and node ignition config assets into separate targets #1119

staebler commented Jan 23, 2019

crawford commented Jan 25, 2019

staebler commented Jan 25, 2019

crawford commented Jan 25, 2019

crawford commented Jan 25, 2019

staebler commented Jan 26, 2019

openshift-ci-robot commented Jan 29, 2019

wking Jan 30, 2019

staebler Jan 30, 2019

wking Jan 30, 2019

staebler Jan 30, 2019

staebler commented Feb 4, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019 •

edited

Loading

staebler commented Feb 16, 2019

staebler commented Feb 20, 2019

staebler commented Feb 21, 2019

openshift-ci-robot commented Feb 22, 2019

staebler commented Feb 25, 2019

openshift-ci-robot commented Mar 3, 2019

staebler commented Apr 22, 2019

openshift-ci-robot commented Apr 22, 2019

create: separate bootstrap and node ignition config assets into separate targets #1119

create: separate bootstrap and node ignition config assets into separate targets #1119

Conversation

staebler commented Jan 23, 2019

crawford commented Jan 25, 2019

staebler commented Jan 25, 2019

crawford commented Jan 25, 2019

crawford commented Jan 25, 2019

staebler commented Jan 26, 2019

openshift-ci-robot commented Jan 29, 2019

wking Jan 30, 2019

Choose a reason for hiding this comment

staebler Jan 30, 2019

Choose a reason for hiding this comment

wking Jan 30, 2019

Choose a reason for hiding this comment

staebler Jan 30, 2019

Choose a reason for hiding this comment

staebler commented Feb 4, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019

staebler commented Feb 15, 2019 • edited Loading

staebler commented Feb 16, 2019

staebler commented Feb 20, 2019

staebler commented Feb 21, 2019

openshift-ci-robot commented Feb 22, 2019

staebler commented Feb 25, 2019

openshift-ci-robot commented Mar 3, 2019

staebler commented Apr 22, 2019

openshift-ci-robot commented Apr 22, 2019

staebler commented Feb 15, 2019 •

edited

Loading