Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create: separate bootstrap and node ignition config assets into separate targets #1119

Closed
wants to merge 2 commits into from
Closed

create: separate bootstrap and node ignition config assets into separate targets #1119

wants to merge 2 commits into from

Commits on Feb 22, 2019

  1. create: separate bootstrap and node ignition config assets into separ… 

    …ate targets

The Bootstrap Ignition asset is dependent upon the Master and Worker Ignition assets.
It is problematic to have them all targeted by the same sub-command because it makes
it difficult for a user to modify all of the ignition configs. These changes create
a new sub-command that targets just the Master and Worker Ignition assets.

The ignition-configs sub-command has been renamed to pre-cluster. This reflects that
the sub-command targets more than just the Bootstrap Ignition asset, as it targets
the kubeconfig and the metadata.json as well.

The new sub-command has been named node-config.

The ignitions-configs sub-command has been deprecated and will be rmeoved once it is
no longer used.

Fixes https://jira.coreos.com/browse/CORS-948
    @staebler
    staebler committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    fc6a6c4 View commit details
    Browse the repository at this point in the history

  2. docs: rebuild dependency graph 

    The ignition-config was split into node-config and pre-cluster targets
so the dependency graph needed to be updated.

Generated with:

$ openshift-install graph | dot -Tsvg >docs/design/resource_dep.svg

using:

$ dot -V
dot - graphviz version 2.40.1 (20161225.0304)
    @staebler
    staebler committed Feb 22, 2019
    Configuration menu
    Copy the full SHA
    69b980d View commit details
    Browse the repository at this point in the history