pkg/terraform/exec/plugins: vendor in azure terraform provider #1664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serbrech
force-pushed
the
vendor-in-azure-provider
branch
from
9951b68
to
d31d41e
Compare
openshift-ci-robot
added
the
size/XXL
serbrech
force-pushed
the
vendor-in-azure-provider
branch
from
d31d41e
to
5594f2d
Compare
serbrech
force-pushed
the
vendor-in-azure-provider
branch
from
5594f2d
to
6dcdb2e
Compare
|
/retest |
- vendor the azurerm terraform provider under the plugins package - add terraform/helper/acctest as a required package to the exec package to satisfy the azurerm provider. - overrides github.com/hashicorp/go-azure-helpers to not get the latest 0.4.0 as it contains has breaking changes
The random provider is needed for azure to generate a storage account name that is unique across azure. storage account names also have extra naming restrictions. is used to keep this in the package and avoid passing an extra parameter as a variable. The local provider is necessary to upload the ignition file to azure storage because the azure provider does not support binary upload. we need to create a file and pass it to the blob upload resource instead. tf blob storage resource : https://www.terraform.io/docs/providers/azurerm/r/storage_blob.html storage naming limits : https://docs.microsoft.com/en-us/azure/architecture/best-practices/naming-conventions#storage
serbrech
force-pushed
the
vendor-in-azure-provider
branch
from
6dcdb2e
to
d20d833
Compare
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, serbrech The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendoring the latest terraform provider in the plugin package
related PR: #1663