configs/installer: increase the resource limits for all image builds

[abhinavdahiya]

With addition of azure terraform plugins 1, looks like the installer builds are failing because of OOMKilled 2

/cc @wking @staebler

[stevekuznetsov]

Is it valid to add limits to builds? @smarterclayton @bparees

[bparees]

Is it valid to add limits to builds? @smarterclayton @bparees

the build api supports it, if that's what you're asking.

whatever you put here:
https://github.com/openshift/api/blob/master/build/v1/types.go#L71

will be translated onto the build pod that's created.

[smarterclayton]

Memory limits yes, helps ensure the correct thing gets oomkilled. Something is going to die, we want it to be guy who went bad

[bparees]

Something is going to die, we want it to be guy who went bad

https://www.youtube.com/watch?v=d73XkPQPKiY

[wking]

I don't understand how these keys tie us to the openshift-install compilation step. Maybe we want to restore just the bin key I seem to have accidentally removed in 3f2f01c (#1677)? Which was maybe originally from 0b1cdda (#891)?

[abhinavdahiya]

using it similar to unit https://github.com/openshift/release/pull/3588/files/c589ac71aed9634a04298e1b3126fab5b52a281a#diff-f9121dca038210d2d38e2713d851b4efR96

[wking]

using it similar to unit

Yup, although I'd be surprised if wee needed 5 GiB memory for our unit tests. And I'm still not clear how these are supposed to work, but I worry that this line is getting limits/requests for our UPI jobs (which are probably fine already) instead of for the compilation job that the UPI tests depend on. Does the CI output show this worked?

[abhinavdahiya]

Does the CI output show this worked?

yes the build jobs for rehearse had the correct resource requests/limits for build pods.

[openshift-ci-robot]

@abhinavdahiya: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/installer/master/e2e-openstack	c589ac7	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-rhel-scaleup	c589ac7	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-vsphere	c589ac7	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-aws	c589ac7	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-metal	c589ac7	link	/test pj-rehearse
ci/rehearse/openshift/installer/master/e2e-libvirt	c589ac7	link	/test pj-rehearse
ci/prow/pj-rehearse	c589ac7	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[wking]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ci-operator/config/openshift/installer/OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@abhinavdahiya: Updated the following 2 configmaps:

• ci-operator-master-configs configmap in namespace ci using the following files:
  • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml
• ci-operator-master-configs configmap in namespace ci-stg using the following files:
  • key openshift-installer-master.yaml using file ci-operator/config/openshift/installer/openshift-installer-master.yaml

In response to this:

With addition of azure terraform plugins 1, looks like the installer builds are failing because of OOMKilled 2

/cc @wking @staebler

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.