Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand how these keys tie us to the
openshift-install
compilation step. Maybe we want to restore just thebin
key I seem to have accidentally removed in 3f2f01c (#1677)? Which was maybe originally from 0b1cdda (#891)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using it similar to unit https://github.com/openshift/release/pull/3588/files/c589ac71aed9634a04298e1b3126fab5b52a281a#diff-f9121dca038210d2d38e2713d851b4efR96
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, although I'd be surprised if wee needed 5 GiB memory for our unit tests. And I'm still not clear how these are supposed to work, but I worry that this line is getting limits/requests for our UPI jobs (which are probably fine already) instead of for the compilation job that the UPI tests depend on. Does the CI output show this worked?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the build jobs for rehearse had the correct resource requests/limits for build pods.