Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

etcd: move etcd service to openshift-etcd #1665

Merged
merged 2 commits into from
Apr 24, 2019

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Apr 23, 2019

openshift/machine-config-operator#648 has merged. This updates the installer to move resources to the openshift-etcd namespace. The consumers have already been updated and resources exactly match the ones that they're making to avoid thrashing.

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 23, 2019
@abhinavdahiya
Copy link
Contributor

This is only moving the service. please reflect the commit message and pr title to match that.

@mfojtik
Copy link
Contributor

mfojtik commented Apr 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@deads2k deads2k changed the title etcd: move to openshift-etcd etcd: move etcd service to openshift-etcd Apr 24, 2019
@deads2k
Copy link
Contributor Author

deads2k commented Apr 24, 2019

This is only moving the service. please reflect the commit message and pr title to match that.

updated

@mfojtik
Copy link
Contributor

mfojtik commented Apr 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
etcd has moved to openshift-etcd.  This reflects that change and the consuming
components have already been updated to handle it.
@wking
Copy link
Member

wking commented Apr 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@wking
Copy link
Member

wking commented Apr 24, 2019

e2e-aws:

level=fatal msg="waiting for Kubernetes API: context deadline exceeded"

Hrm.

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants