-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move etcd to openshift-etcd #648
Conversation
@runcom is there any log on the bootstrap host (or better yet a directory) containing the content used to create the initial hash to make this easier to debug? If we had a directory, we'd be able to pull it out with install-gather. |
directories in this file is what you need https://github.com/openshift/machine-config-operator/blob/master/manifests/bootstrap-pod-v2.yaml basically /etc/mcc/boostrap, /etc/mcs/boostrap, /etc/ssl/mcs and /etc/mcs/kubeconfig everything in those dirs is what the bootstrap serves so if you have the rendered in cluster MC and the one in bootstrap you can diff Also, I believe that with #612, if, from now on, there will be a drift between current bootstrap and current in-cluster, one could simple |
@runcom @sdodson That seems like it would be really valuable for install-gather. |
oh ok cool, I'm sure the dirs from the bootstrap node would definitely contain what we need to debug when there's a skew tho. I'm not entirely sure that dir on the nodes contains anything if we have the drift right at boot. I think gathering |
Thanks. It'll keep until Monday, but I have ended up in this spot many times and it's always been a guess and check mode of getting out of it. In this case, it must be something to do with etcd pod or certs that has namespace references and isn't in the files I touched here. They clearly come out correctly because everything directly using etcd is working fine. |
New app flake only /retest |
Unauthorized /retest |
network flake I've seen in other pulls
/retest |
green and conflicts. rebasing 3 green CI installs so far. |
another install success /test e2e-aws |
infra timeout |
/test e2e-aws-op |
@deads2k is there a BZ/open issue somewhere for this change? |
It's related to API freeze and committing to names and namespaces "forever". /hold waiting for more e2e results. |
@deads2k great! can we add that to the commit message body?? 😃 |
@kikisdeliveryservice It's you again! :) Sure, after these tests complete. |
Moves etcd to openshift-etcd namespace. This is related to API freeze, where we commit to names and namespaces for the foreseeable future. After this, operators make the switch permanently (many are bilingual right now), and we remove the old dns names from the cert.
Now with updated commit message. @runcom ptal. I think you lgtm'd via slack before. I plan to release the hold for merge early tomorrow AM. |
/hold cancel tag/merge at will in your tomorrow (wednesday) AM. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Service catalog pull is ready and lgtm'd, notifications made, got the ok to merge tonight. Let's go! /hold cancel |
Moves etcd to openshift-etcd namespace. This is related to API freeze, where we commit to names and namespaces for the foreseeable future.
After this, operators make the switch permanently (many are bilingual right now), and we remove the old dns names from the cert.
10 successful CI installs so far