-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
installer: stop validating the etcd node pool #179
installer: stop validating the etcd node pool #179
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
etcd nodes are no longer created. There is no need to validate their config. This is seperate from the complete removal of etcd in order to _try_ not to break CI.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws |
We ought to use the same yaml package used by clientconfig in order to marshall/unmarshall Auth structs to/from yaml correctly. Using any other yaml library will fail to load the auth data from secrets.
etcd nodes are no longer created. There is no need to validate their
config. This is seperate from the complete removal of etcd in order to
try not to break CI.