Revert "cluster-launch-installer-e2e: remove etcd nodes" #1284
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eparis If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/M
|
@eparis: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
We should be able to revert this reversion with openshift/installer#179 landed. |
|
We can delete the |
Until we can re-land [1] (which is currently reverted by [2]). With the etcd node pool still defined in the release template, we're getting [3]: time="2018-08-27T18:50:53Z" level=fatal msg="unrecognized role: etcd" With this commit, we ignore that entry (just as Go's JSON and YAML unmarshallers ignore other properties which aren't reflected in the target Go structures). A better long-term fix would probably be adding more structure to node pools, but I'm punting on that for now. [1]: openshift/release#1274 [2]: openshift/release#1284 [3]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/168/pull-ci-origin-installer-e2e-aws/710/build-log.txt
Until we can re-land [1] (which is currently reverted by [2]). With the etcd node pool still defined in the release template, we're getting [3]: time="2018-08-27T18:50:53Z" level=fatal msg="unrecognized role: etcd" With this commit, we ignore that entry (just as Go's JSON and YAML unmarshallers ignore other properties which aren't reflected in the target Go structures). A better long-term fix would probably be adding more structure to node pools, but I'm punting on that for now. [1]: openshift/release#1274 [2]: openshift/release#1284 [3]: https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_installer/168/pull-ci-origin-installer-e2e-aws/710/build-log.txt
Reverts #1274
https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_installer/176/pull-ci-origin-installer-e2e-aws/682/
@crawford @wking