cmd: gather the logs from bootstrap instead of printing commands #2840
Conversation
The package allows users to create a new SSH client that - Uses an SSH agent to provide authentication - Either uses the keys from paths explicity provided, or loads all the keys from `~/.ssh` to use for authentication The package also provides a way to Run a command using an SSH client. The client must be configured to allow SSH agent forwarding. The package also provides a way to pull a file from remote server to a file on the local host using a SSH client.
This changes the gather bootstrap to establish an SSH connection to bootstrap host to gather the logs, rather than printing the commands for the user to execute. This had some trivial conflicts because e4bddc2 (gather: add support for azure, 2019-05-28, openshift#1795) had landed in release-4.2 but does not apply to 4.1, where we have no Azure support.
Error message displays when gather command failed and no ssh keys were passed. The message recommends ensuring ssh keys were in keyring or specifying the key in a flag.
This had some trivial conflicts in the CloudFormation templates because e45521e (Text edits for the CloudFormation templates, 2019-05-28, openshift#1794) wasn't backported to 4.1.
|
@wking: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ather The installer does this automatically since openshift/installer@cad7f02a8b (cmd: gather the logs from bootstrap instead of printing commands, 2019-06-05, openshift/installer#1822). You'd still need to SSH in to gather manually in 4.1.z, but if we think that's important we should backport the gather logic to the installer's 4.1 branch [1]. [1]: openshift/installer#2840
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
4.1 is now EOL /close |
|
@abhinavdahiya: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Backporting #1822 and the subsequent 00307d1 (from #2023) and 2686d73 (from #2106). The commits from later PRs just bring the UX quality up to par with 4.2
Backporting this allows us to drop Terraform-state-poking logic from the release repository (e.g. openshift/release#6336), where it's currently tedious to maintain for no real benefit. I'm happy to file a backport-request bug to hang this on, but thought I'd file the PR first to see if there was any appetite, or if folks would rather keep dragging the release-side workaround along.