pkg/asset/machines/aws/machinesets: Give workers public IPs (for now) #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
|
Can we do something like this installer/pkg/asset/machines/aws/machines.go Line 122 in 8f02020 |
|
@derekwaynecarr we’ll need to commit teams to fix this once we get the full suite switched over |
Workers have not had public IPs since (at least) we moved them to cluster-API creation in e2dc955 (pkg/asset: add ClusterK8sIO, machines.Worker assets, 2018-10-15, openshift#468). But it turns out a number of e2e tests assume SSH access to workers (e.g. [1]), and we don't have time to fix those tests now. We'll remove this once the tests have been fixed. [1]: https://github.com/kubernetes/kubernetes/blob/v1.13.1/test/e2e/node/ssh.go#L43
wking
force-pushed
the
aws-public-worker-ips
branch
from
f490402 to
0055276
Compare
openshift-ci-robot
added
size/S
Sure. Done in f490402 -> 0055276. |
|
When this merges I'll kick another e2e-aws-all run. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: staebler, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workers have not had public IPs since (at least) we moved them to cluster-API creation in e2dc955 (#468). But it turns out a number of e2e tests assume SSH access to workers (e.g. here), and we don't have time to fix those tests now. We'll remove this once the tests have been fixed.
CC @abhinavdahiya, @crawford, @smarterclayton