Revert "pkg/asset/machines/aws/machinesets: Give workers public IPs (for now)" #970
Conversation
|
/assign @wking |
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Looks like the same machine-approver restart issue I'm seeing in #955. |
|
I think that's openshift/cluster-machine-approver#8 I think Im' going ot revert it. |
|
I have openshift/cluster-machine-approver#9 open, if it is green I will merge |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Through c0104bd (Merge pull request openshift#970 from openshift/revert-927-aws-public-worker-ips, 2018-12-21).
Reverts #927
We didn't quite get all the NAT settings working. After more discussion Eric made the convincing argument to just fix the conformance tests (since he didn't have to implement it) which is what openshift/origin#21700 demonstrates. In order for that to work, we have to revert this because the masters can't reach the workers on their external IP which the conformance tests try to look up automatically.