Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Apr 28, 2025

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Option 01) PoC - Opt-in service type loadbalancer NLB with SG:

Cluster bot builder:

build 4.20,openshift/api#2299,openshift/cluster-ingress-operator#1224,openshift/cloud-provider-aws#107,openshift/installer#9681

Option 02) PoC - Enforce provision service type loadbalancer NLB with SG using cloud-config:

Cluster bot builder:

build 4.20,openshift/cloud-provider-aws#108,openshift/cluster-cloud-controller-manager-operator#391,openshift/installer#9681

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rna-afk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Cluster bot builder:

build openshift/api#2299,openshift/cluster-ingress-operator#1224,openshift/cloud-provider-aws#107,openshift/installer#9681

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio force-pushed the SPLAT-2113 branch 5 times, most recently from 9f45a3d to 69d6136 Compare May 3, 2025 03:17
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 6, 2025

@mtulio: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 69d6136 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Option 01) PoC - Opt-in service type loadbalancer NLB with SG:

Cluster bot builder:

build openshift/api#2299,openshift/cluster-ingress-operator#1224,openshift/cloud-provider-aws#107,openshift/installer#9681

Option 02) PoC - Enforce provision service type loadbalancer NLB with SG using cloud-config:

Cluster bot builder:

build openshift/cloud-provider-aws#108,openshift/cluster-cloud-controller-manager-operator/pull/391,openshift/installer#9681

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 2, 2025

@mtulio: This pull request references SPLAT-2113 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.20.0" version, but no target version was set.

In response to this:

Draft for spike EP for NLB SGs on CIO on install time.

Related to:

Option 01) PoC - Opt-in service type loadbalancer NLB with SG:

Cluster bot builder:

build 4.20,openshift/api#2299,openshift/cluster-ingress-operator#1224,openshift/cloud-provider-aws#107,openshift/installer#9681

Option 02) PoC - Enforce provision service type loadbalancer NLB with SG using cloud-config:

Cluster bot builder:

build 4.20,openshift/cloud-provider-aws#108,openshift/cluster-cloud-controller-manager-operator#391,openshift/installer#9681

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Jun 11, 2025

Closing as Won't Do as the approach will be changing the CCM to support SG when Service type-LoadBalancer NLB when cloud-config is enabled (enforced by CCCMO).

No Installer changes will be required using that approach.

See SPLAT-2253 and enhancement SPLAT-2187 for more details.

@mtulio mtulio closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants