Skip to content

SPLAT-2253/WIP: CCM-AWS config enforce to provision Service NLB with SG under gate #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

SPLAT-2253/WIP: CCM-AWS config enforce to provision Service NLB with SG under gate #391

wants to merge 3 commits into from

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Jun 2, 2025 •
edited
Loading

Bumping cloud-provider-aws to gather the NLB+SG feature, enabling the configuration to provision SGs for all NLBs through the sync transformer.

Ref: openshift/cloud-provider-aws#117

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 2, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mtulio mtulio mentioned this pull request Jun 2, 2025
Closed
@mtulio mtulio changed the title tmp/DNM: validating NLB+SG config DNM/SPLAT-2253: tmp validation of NLB+SG setup Jun 2, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 2, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 2, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2253 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Bumping cloud-provider-aws are crashing, focusing in the change for now to be able to validate with cluster-bot.

this PR is created to be used with cluster-bot:

Ref: openshift/cloud-provider-aws#108

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nrb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor Author

mtulio commented Jul 24, 2025

/test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 24, 2025

@mtulio: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify-deps f7d8233 link true /test verify-deps
ci/prow/vendor f7d8233 link true /test vendor
ci/prow/vet f7d8233 link true /test vet
ci/prow/unit f7d8233 link true /test unit
ci/prow/fmt f7d8233 link true /test fmt
ci/prow/lint f7d8233 link true /test lint

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mtulio mtulio changed the title DNM/SPLAT-2253: tmp validation of NLB+SG setup DNM/SPLAT-2253: CCM-AWS config enforce to provision Service NLB with SG under gate Jul 24, 2025
@mtulio mtulio mentioned this pull request Jul 25, 2025
Merged
@mtulio
Copy link
Contributor Author

mtulio commented Sep 10, 2025

PR rebased with upstream updates, and CCCMO FG support by #400

@mtulio
Copy link
Contributor Author

mtulio commented Sep 10, 2025

Next step: create a CI job to exercise this scenario.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 10, 2025

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 10, 2025

@mtulio: The following commands are available to trigger required jobs:

/test e2e-aws-ovn

/test e2e-aws-ovn-upgrade

/test fmt

/test images

/test lint

/test okd-scos-images

/test security

/test unit

/test vendor

/test verify-deps

/test vet

The following commands are available to trigger optional jobs:

/test e2e-azure-manual-oidc

/test e2e-azure-ovn

/test e2e-azure-ovn-upgrade

/test e2e-gcp-ovn

/test e2e-gcp-ovn-upgrade

/test e2e-ibmcloud-ovn

/test e2e-nutanix-ovn

/test e2e-openstack-ovn

/test e2e-vsphere-ovn

/test level0-clusterinfra-azure-ipi-proxy-tests

/test okd-scos-e2e-aws-ovn

/test regression-clusterinfra-vsphere-ipi-ccm

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-upgrade

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-azure-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-azure-ovn-upgrade

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-gcp-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-gcp-ovn-upgrade

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-openstack-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-vsphere-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-fmt

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-images

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-level0-clusterinfra-azure-ipi-proxy-tests

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-lint

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-okd-scos-e2e-aws-ovn

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-okd-scos-images

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-regression-clusterinfra-vsphere-ipi-ccm

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-security

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-unit

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-vendor

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-verify-deps

pull-ci-openshift-cluster-cloud-controller-manager-operator-main-vet

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio mtulio mentioned this pull request Sep 11, 2025
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 11, 2025 •
edited by openshift-ci bot
Loading

@mtulio: This pull request references SPLAT-2253 which is a valid jira issue.

In response to this:

Bumping cloud-provider-aws are crashing, focusing in the change for now to be able to validate with cluster-bot.

this PR is created to be used with cluster-bot:

Ref: openshift/cloud-provider-aws#117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio changed the title DNM/SPLAT-2253: CCM-AWS config enforce to provision Service NLB with SG under gate SPLAT-2253/WIP: CCM-AWS config enforce to provision Service NLB with SG under gate Sep 17, 2025
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 17, 2025
@openshift-ci-robot
Copy link

@mtulio: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

Bumping cloud-provider-aws are crashing, focusing in the change for now to be able to validate with cluster-bot.

this PR is created to be used with cluster-bot:

Ref: openshift/cloud-provider-aws#117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 17, 2025

/payload-job ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2025

@mtulio: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 17, 2025 •
edited
Loading

/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/origin#30235 openshift/cloud-provider-aws#117

@mtulio
feat/aws-ccm-nlb-sg: enforce to managed mode
525112b 
Enforce CCM to managed SG for NLBs.
@mtulio mtulio mentioned this pull request Sep 18, 2025
Open
@deepsm007
Copy link

/testwith openshift/cluster-cloud-controller-manager-operator/main/e2e-aws-ovn openshift/cloud-provider-aws#117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtulio @openshift-ci-robot @deepsm007