-
Notifications
You must be signed in to change notification settings - Fork 2k
SPLAT-2501: TechPreview jobs for o/CCM-AWS and CCCMO to NLB+SG feature #69181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPLAT-2501: TechPreview jobs for o/CCM-AWS and CCCMO to NLB+SG feature #69181
Conversation
|
@mtulio: This pull request references SPLAT-2501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@mtulio: This pull request references SPLAT-2501 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b729292 to
4ac5d5a
Compare
|
/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-tech-preview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Inspecting the CCCMO logs from the cluster ci-op-54ht3vx4-393de created from 1966194933719109632, I can see TP gates: $ oc whoami --show-server
https://api.ci-op-54ht3vx4-393de.origin-ci-int-aws.dev.rhcloud.com:6443
$ oc logs pod/cluster-cloud-controller-manager-operator-79f98b59-nzz7t \
-n openshift-cloud-controller-manager-operator -c config-sync-controllers \
| grep -o AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroupOn the cluster created to the CCM rehearsal, , created from 1966194933798801408, I can see: $ oc whoami --show-server
https://api.ci-op-j8nyx4x4-b0a32.origin-ci-int-aws.dev.rhcloud.com:6443
$ oc get pods -n openshift-cloud-controller-manager-operator
NAME READY STATUS RESTARTS AGE
cluster-cloud-controller-manager-operator-b55949bc6-qs7n5 3/3 Running 5 (36m ago) 38m
sh-5.1$ oc logs cluster-cloud-controller-manager-operator-b55949bc6-qs7n5 -c config-sync-controllers -n openshift-cloud-controller-manager-operator | grep -o AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup |
|
Both jobs failed e2e for same reason: I am converting this PR to draft to:
|
4ac5d5a to
a11ae07
Compare
|
/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio: job(s): pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@mtulio, If the problem persists, please contact Test Platform. |
a11ae07 to
902db4d
Compare
|
making new step to use upi-image, which provides awscli. I am also hooking with step to use NLB in the default router service, intent of the feature: /pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
902db4d to
560cd7d
Compare
|
Latest run wen't well, but I missed setting AWS region to use aws cli calls, set it I also added a new workflow to enforce NLB and prevent disrupting in existing ones, so we will decrease the scope/impact of changes introduced here, focusing more in the NLB+SG feature using TP. /pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
560cd7d to
ea953d4
Compare
|
Got the expected results, I just did more fine tuning of the final result file when CLB and will run one more time: /pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
0e15bbe to
740e1f5
Compare
|
This PR is ready for review again. PTAL? |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/approve |
Introduce optional presubmit and presubmit jobs for CCM-AWS and CCCMO projects using feature set TechPreview to test gates under this set, including the NLB+SG feature. Additionally, the e2e-aws-ccm workflow is now collecting the loadbalancer information from a service (router as example).
740e1f5 to
4202700
Compare
|
rebased to regenerate the registry-metadata removing inactive user removed by #69653 (comment) |
|
/lgtm |
/pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/pj-rehearse ack |
|
@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko, jcpowermac, mtulio, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…9181) Introduce optional presubmit and presubmit jobs for CCM-AWS and CCCMO projects using feature set TechPreview to test gates under this set, including the NLB+SG feature. Additionally, the e2e-aws-ccm workflow is now collecting the loadbalancer information from a service (router as example).
…9181) Introduce optional presubmit and presubmit jobs for CCM-AWS and CCCMO projects using feature set TechPreview to test gates under this set, including the NLB+SG feature. Additionally, the e2e-aws-ccm workflow is now collecting the loadbalancer information from a service (router as example).
Introduce optional presubmit jobs on CCM-AWS and CCCMO projects, and one Periodic, using feature set TechPreview to test gates under this set, including the NLB+SG feature.
The presubmit job for cloud-provider-aws will validate the upstream features in the downstream sync PR[1], while the presubmit for CCCMO will validate the cloud-config enforcement[2], it requires [1] to be in place. I am checking if we can run a payload job with [1] and [2]
Refs: