Skip to content

Conversation

@mtulio
Copy link
Contributor

@mtulio mtulio commented Sep 11, 2025

Introduce optional presubmit jobs on CCM-AWS and CCCMO projects, and one Periodic, using feature set TechPreview to test gates under this set, including the NLB+SG feature.

The presubmit job for cloud-provider-aws will validate the upstream features in the downstream sync PR[1], while the presubmit for CCCMO will validate the cloud-config enforcement[2], it requires [1] to be in place. I am checking if we can run a payload job with [1] and [2]

Refs:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2025

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Introduce optional presubmit jobs on CCM-AWS and CCCMO projects using feature set TechPreview to test gates under this set, including the NLB+SG feature.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from damdo and elmiko September 11, 2025 17:11
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2025

@mtulio: This pull request references SPLAT-2501 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

In response to this:

Introduce optional presubmit jobs on CCM-AWS and CCCMO projects using feature set TechPreview to test gates under this set, including the NLB+SG feature.

Refs:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from b729292 to 4ac5d5a Compare September 11, 2025 17:32
@mtulio
Copy link
Contributor Author

mtulio commented Sep 11, 2025

/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-tech-preview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 11, 2025

Inspecting the CCCMO logs from the cluster ci-op-54ht3vx4-393de created from 1966194933719109632, I can see TP gates:

$ oc whoami --show-server
https://api.ci-op-54ht3vx4-393de.origin-ci-int-aws.dev.rhcloud.com:6443

$ oc logs pod/cluster-cloud-controller-manager-operator-79f98b59-nzz7t  \
-n openshift-cloud-controller-manager-operator -c config-sync-controllers \
| grep -o AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup

On the cluster created to the CCM rehearsal, , created from 1966194933798801408, I can see:

$ oc whoami --show-server
https://api.ci-op-j8nyx4x4-b0a32.origin-ci-int-aws.dev.rhcloud.com:6443

$ oc get pods -n  openshift-cloud-controller-manager-operator
NAME                                                        READY   STATUS    RESTARTS      AGE
cluster-cloud-controller-manager-operator-b55949bc6-qs7n5   3/3     Running   5 (36m ago)   38m
sh-5.1$ oc logs cluster-cloud-controller-manager-operator-b55949bc6-qs7n5 -c config-sync-controllers -n  openshift-cloud-controller-manager-operator | grep -o AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup
AWSServiceLBNetworkSecurityGroup

@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

Both jobs failed e2e for same reason: [sig-ci] [Early] prow job name should match feature set [Suite:openshift/conformance/parallel]

I am converting this PR to draft to:

  • rename the jobs
  • implement the ccm-gather-service-aws step to collect more information of an service LB provisioned by CCM (ingress).

@mtulio mtulio marked this pull request as draft September 12, 2025 13:34
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 12, 2025
@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from 4ac5d5a to a11ae07 Compare September 12, 2025 14:42
@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mtulio: job(s): pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-tech-preview either don't exist or were not found to be affected, and cannot be rehearsed

@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

/pj-rehearse pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-techpreview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mtulio, pj-rehearse: unable to determine affected jobs ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 45d8da9ba9e0c12b391fe689c665dbfe8f2dc96a]' failed with out:  and error exec: Stdout already set

If the problem persists, please contact Test Platform.

@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from a11ae07 to 902db4d Compare September 12, 2025 16:50
@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

making new step to use upi-image, which provides awscli. I am also hooking with step to use NLB in the default router service, intent of the feature:

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from 902db4d to 560cd7d Compare September 12, 2025 18:33
@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

Latest run wen't well, but I missed setting AWS region to use aws cli calls, set it I also added a new workflow to enforce NLB and prevent disrupting in existing ones, so we will decrease the scope/impact of changes introduced here, focusing more in the NLB+SG feature using TP.

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 12, 2025
@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from 560cd7d to ea953d4 Compare September 12, 2025 20:21
@mtulio
Copy link
Contributor Author

mtulio commented Sep 12, 2025

Got the expected results, I just did more fine tuning of the final result file when CLB and will run one more time:

/pj-rehearse periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Sep 12, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 23, 2025
@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from 0e15bbe to 740e1f5 Compare September 24, 2025 18:12
@mtulio mtulio requested a review from vrutkovs September 24, 2025 18:13
@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

This PR is ready for review again. PTAL?
/hold cancel
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2025
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 24, 2025
@elmiko
Copy link
Contributor

elmiko commented Sep 24, 2025

/approve
/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2025
Introduce optional presubmit and presubmit jobs for CCM-AWS and
CCCMO projects using feature set TechPreview to test gates under
this set, including the NLB+SG feature.

Additionally, the e2e-aws-ccm workflow is now collecting the
loadbalancer information from a service (router as example).
@mtulio mtulio force-pushed the SPLAT-2501-ccm-nlb-sg branch from 740e1f5 to 4202700 Compare September 24, 2025 19:49
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

rebased to regenerate the registry-metadata removing inactive user removed by #69653 (comment)

@jcpowermac
Copy link
Contributor

/lgtm

@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

rebased to regenerate the registry-metadata removing inactive user removed by #69653 (comment)

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added rehearsals-ack Signifies that rehearsal jobs have been acknowledged and removed rehearsals-ack Signifies that rehearsal jobs have been acknowledged labels Sep 24, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-cloud-controller-manager-operator-main-e2e-aws-ovn-techpreview openshift/cluster-cloud-controller-manager-operator presubmit Presubmit changed
pull-ci-openshift-cloud-provider-aws-main-e2e-aws-ovn-techpreview openshift/cloud-provider-aws presubmit Presubmit changed
periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ccm-techpreview N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mtulio
Copy link
Contributor Author

mtulio commented Sep 24, 2025

/pj-rehearse ack

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mtulio: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Sep 24, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, jcpowermac, mtulio, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 478dd9b into openshift:master Sep 24, 2025
17 checks passed
@mtulio mtulio deleted the SPLAT-2501-ccm-nlb-sg branch September 24, 2025 21:06
xiaojiey pushed a commit to xiaojiey/release that referenced this pull request Sep 25, 2025
…9181)

Introduce optional presubmit and presubmit jobs for CCM-AWS and
CCCMO projects using feature set TechPreview to test gates under
this set, including the NLB+SG feature.

Additionally, the e2e-aws-ccm workflow is now collecting the
loadbalancer information from a service (router as example).
abhay-nutanix pushed a commit to abhay-nutanix/release that referenced this pull request Oct 16, 2025
…9181)

Introduce optional presubmit and presubmit jobs for CCM-AWS and
CCCMO projects using feature set TechPreview to test gates under
this set, including the NLB+SG feature.

Additionally, the e2e-aws-ccm workflow is now collecting the
loadbalancer information from a service (router as example).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants