Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets #1939

Merged
merged 1 commit into from
Apr 9, 2024
Merged

OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets #1939

merged 1 commit into from
Apr 9, 2024

Conversation

p0lyn0mial
Copy link

@tkashem @p0lyn0mial
UPSTREAM: <carry>: allow type mutation for specific secrets
a307a04 
This is a short term fix, once we improve the cert rotation logic
in library-go that does not depend on this hack, then we can
remove this carry patch.
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Apr 5, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@p0lyn0mial
Copy link
Author

/assign @tkashem @vrutkovs

@openshift-ci openshift-ci bot requested review from mfojtik and soltysh April 5, 2024 11:23
@p0lyn0mial
Copy link
Author

/hold

until we get signal from CI/nightly and the QE team.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@p0lyn0mial p0lyn0mial changed the title UPSTREAM: <carry>: allow type mutation for specific secrets OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets Apr 5, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 5, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Jira Issue OCPBUGS-31807, which is invalid:

  • expected dependent Jira Issue OCPBUGS-31384 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

back port of:

was clean.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tkashem
Copy link

tkashem commented Apr 5, 2024

/remove-label backports/unvalidated-commits
/label backports/validated-commits

/cc @soltysh

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 5, 2024
@tkashem
Copy link

tkashem commented Apr 5, 2024

/lgtm
/approve

@tkashem
Copy link

tkashem commented Apr 5, 2024

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Apr 5, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2024
@tkashem
Copy link

tkashem commented Apr 5, 2024

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@p0lyn0mial
Copy link
Author

ci/prow/uni failed on TestPrintIPAddressList. The test seems unstable, it also failed in:

@tkashem
Copy link

tkashem commented Apr 5, 2024

/test unit

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: p0lyn0mial, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@p0lyn0mial
Copy link
Author

Actually it looks like TestPrintIPAddressList will be fixed by d216da4 in #1926

@tkashem
Copy link

tkashem commented Apr 5, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 5, 2024 •
edited
Loading

@p0lyn0mial: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd a307a04 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-csi a307a04 link false /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@p0lyn0mial
Copy link
Author

/retest-required

@p0lyn0mial
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2024
@openshift-ci-robot
Copy link

@p0lyn0mial: This pull request references Jira Issue OCPBUGS-31807, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-31384 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-31384 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 April 9, 2024 07:53
@p0lyn0mial
Copy link
Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 9, 2024
@p0lyn0mial
Copy link
Author

/label cherry-pick-approved

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 9, 2024

@p0lyn0mial: Can not set label cherry-pick-approved: Must be member in one of these teams: [openshift-staff-engineers]

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 9, 2024
Merged
@gangwgr
Copy link

gangwgr commented Apr 9, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2024
@p0lyn0mial p0lyn0mial mentioned this pull request Apr 9, 2024
Merged
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 359ecc8 and 2 for PR HEAD a307a04 in total

@openshift-merge-bot openshift-merge-bot bot merged commit b72e6fa into openshift:release-4.15 Apr 9, 2024
17 of 19 checks passed
@openshift-ci-robot
Copy link

@p0lyn0mial: Jira Issue OCPBUGS-31807: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31807 has not been moved to the MODIFIED state.

In response to this:

back port of:

was clean.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tkashem tkashem mentioned this pull request Apr 9, 2024
Merged
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.15.0-202404091240.p0.gb72e6fa.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

@openshift-merge-robot
Copy link

Fix included in accepted release 4.15.0-0.nightly-2024-04-16-070254

wking added a commit to wking/cincinnati-graph-data that referenced this pull request Apr 19, 2024
@wking
blocked-edges/4.15.9-EarlyAPICertRotation: Fixed in 4.15.10
13a3887 
We thought this was fixed in rc.1, but it wasn't, c74c248
(blocked-edges/4.15.0*-EarlyAPICertRotation: Extend to more recent
RCs, 2024-02-26, openshift#4841).

Then we thought it was fixed in 4.15.2, but it wasn't, b474a45
(blocked-edges/4.15.3-EarlyAPICertRotation: Extend to 4.15.2 and .3,
2024-03-25, openshift#4981).

Now we think it's fixed in 4.15.10 [1], wihch contains all three of:

* openshift/cluster-kube-apiserver-operator#1662: OCPBUGS-31807: Use RotatedSigningCASecret in update only mode
* openshift/cluster-kube-controller-manager-operator#801: OCPBUGS-31807: use RotatedSigningCASecret and RotatedSelfSignedCertKeySecret only in update mode
* openshift/kubernetes#1939: OCPBUGS-31807: UPSTREAM: <carry>: allow type mutation for specific secrets

[1]: https://amd64.ocp.releases.ci.openshift.org/releasestream/4-stable/release/4.15.10
@wking wking mentioned this pull request Apr 19, 2024
Merged
@p0lyn0mial p0lyn0mial mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@soltysh soltysh Awaiting requested review from soltysh

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@vrutkovs vrutkovs

@kasturinarra kasturinarra

@tkashem tkashem

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@sunilcio sunilcio

@duanwei33 duanwei33

@wangke19 wangke19

@gangwgr gangwgr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.