Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resourceread: Add images #1331

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

cgwalters
Copy link
Member

I want to read an imagestream from a file in the MCO, for the
same reason the CVO is doing. This code could replace the
bits in the CVO for it.

I want to read an imagestream from a file in the MCO, for the
same reason the CVO is doing.  This code could replace the
bits in the CVO for it.
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 13, 2022
@cgwalters
Copy link
Member Author

Ping, any reviewers here?

@deads2k
Copy link
Contributor

deads2k commented Jul 13, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 13, 2022

@cgwalters: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit ca167a8 into openshift:master Jul 13, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 19, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 20, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 21, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 21, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 21, 2022
jkyros pushed a commit to jkyros/machine-config-operator that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants