operator/bootstrap: Accept new --image-references argument #3017
Conversation
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Depends: openshift/library-go#1331 /test unit |
cgwalters
changed the title
The MCO orchestrates the management/setup of a big pile of different containers today, from `machine-os-content` to `haproxy` and configuring cri-o to use the correct `pause`/`pod` container. These images get set up at both "bootstrap" time and cluster time. In bootstrap today we manually scrape each image out of the CVO in shell script, and then pass them as CLI arguments inside `bootkube.sh`. This means adding new images requires a tedious "ratcheting" process where the CLI argument is added to the MCO, then we patch the installer to pass it in. Instead, add a new CLI argument which accepts a serialized imagestream object, which is exactly what the CVO carries. Prep for adding a new `rhel-coreos` image into the payload, so I can avoid that ratcheting process.
cgwalters
force-pushed
the
read-imagestream-directliy
branch
from
1d1cfee
to
014e895
Compare
|
/test unit |
Depends: openshift/machine-config-operator#3017 I want to add a new image (e.g. `rhel-coreos` as part of layering) and this will avoid a tedious "ratching" process to plumb that through the installer. Now the MCO can just directly read the image references.
|
/test unit |
|
I'm going to retarget this one for layering, but we need #3018 |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@cgwalters: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
So...if we end up not adding a new |
is this still relevant ^^^ |
|
I would like to do this yes, because it will make it much less painful in the future to add (or change/remove) images. |
I meant the ref to the library go PR being a prereq for merging 😄 |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
|
OK openshift/library-go#1331 merged, so I think this just needs a lgtm! |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
So...yeah. The bumping of library-go as expected snowballed a bit. I started on this in #3252 I personally vote to get this in so we don't block on that. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
operator/bootstrap: Accept new
--image-referencesargumentThe MCO orchestrates the management/setup of a big pile of different
containers today, from
machine-os-contenttohaproxyandconfiguring cri-o to use the correct
pause/podcontainer.These images get set up at both "bootstrap" time and cluster time.
In bootstrap today we manually scrape each image out of the CVO in
shell script, and then pass them as CLI arguments inside
bootkube.sh.This means adding new images requires a tedious "ratcheting" process
where the CLI argument is added to the MCO, then we patch the installer
to pass it in.
Instead, add a new CLI argument which accepts a serialized imagestream
object, which is exactly what the CVO carries.
Prep for adding a new
rhel-coreosimage into the payload, so I canavoid that ratcheting process.