Skip to content

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Jun 24, 2025

https://issues.redhat.com/browse/STOR-2331

Manually verified:

  1. These NetworkPolicy manifests are deployed to the same namespace as the operator (openshift-local-storage) when the operator is installed
  2. local-storage-operator, diskmaker-discovery, and diskmaker-manager pods have the correct labels + policies applied. Used nmap to verify expected ingress ports are accessible and others are not.
  3. A standalone pod in the namespace without any labels applied can not reach the outside world (deny-all policy is in effect).

/cc @openshift/storage @mpatlasov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 24, 2025

@dobsonj: This pull request references STOR-2331 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-2331

Manually verified:

  1. These NetworkPolicy manifests are deployed to the same namespace as the operator (openshift-local-storage) when the operator is installed
  2. local-storage-operator, diskmaker-discovery, and diskmaker-manager pods have the correct labels + policies applied. Used nmap to verify expected ingress ports are accessible and others are not.
  3. A standalone pod in the namespace without any labels applied can not reach the outside world (deny-all policy is in effect).

/cc @openshift/storage @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mpatlasov June 24, 2025 20:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

https://issues.redhat.com/browse/STOR-2331

Manually verified:

  1. These NetworkPolicy manifests are deployed to the same namespace as the operator (openshift-local-storage) when the operator is installed
  2. local-storage-operator, diskmaker-discovery, and diskmaker-manager pods have the correct labels + policies applied. Used nmap to verify expected ingress ports are accessible and others are not.
  3. A standalone pod in the namespace without any labels applied can not reach the outside world (deny-all policy is in effect).

/cc @openshift/storage @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 24, 2025

@dobsonj: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mpatlasov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 25, 2025
@ropatil010
Copy link

Adding label and will perform this as post-merge testing since this is 3rd level operator.
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 1, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 1, 2025

@dobsonj: This pull request references STOR-2331 which is a valid jira issue.

Details

In response to this:

https://issues.redhat.com/browse/STOR-2331

Manually verified:

  1. These NetworkPolicy manifests are deployed to the same namespace as the operator (openshift-local-storage) when the operator is installed
  2. local-storage-operator, diskmaker-discovery, and diskmaker-manager pods have the correct labels + policies applied. Used nmap to verify expected ingress ports are accessible and others are not.
  3. A standalone pod in the namespace without any labels applied can not reach the outside world (deny-all policy is in effect).

/cc @openshift/storage @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 77aa6bf into openshift:main Jul 1, 2025
9 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-operator
This PR has been included in build local-storage-operator-container-v4.20.0-202507012145.p0.g77aa6bf.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-mustgather
This PR has been included in build ose-local-storage-mustgather-container-v4.20.0-202507012145.p0.g77aa6bf.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: local-storage-diskmaker
This PR has been included in build local-storage-diskmaker-container-v4.20.0-202507012145.p0.g77aa6bf.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants