Skip to content

Conversation

@dobsonj
Copy link
Member

@dobsonj dobsonj commented Aug 13, 2025

This PR is a rework of #530 (reverted in #539) to deploy network policies only for operands as requested in OCPSTRAT-819.

It adds a new controller to the operator to reconcile network policies for the operands.

Depends on openshift/library-go#1992

/cc @mpatlasov

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 13, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 13, 2025

@dobsonj: This pull request references STOR-2331 which is a valid jira issue.

Details

In response to this:

This PR is a rework of #530 (reverted in #539) to deploy network policies only for operands as requested in OCPSTRAT-819.

It adds a new controller to the operator to reconcile network policies for the operands.

Depends on openshift/library-go#1992

/cc @mpatlasov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mpatlasov August 13, 2025 17:37
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-extended c843346 link false /test e2e-operator-extended

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dobsonj
Copy link
Member Author

dobsonj commented Aug 14, 2025

We unanimously dislike the extra complexity it takes to deploy NetworkPolicies just for LSO operands without deploying them as part of the OLM bundle, and instead choose to defer this work until we can safely reintroduce the simpler #530 in STOR-2550
/close

@openshift-ci openshift-ci bot closed this Aug 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@dobsonj: Closed this PR.

Details

In response to this:

We unanimously dislike the extra complexity it takes to deploy NetworkPolicies just for LSO operands without deploying them as part of the OLM bundle, and instead choose to defer this work until we can safely reintroduce the simpler #530 in STOR-2550
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants