[OCPCLOUD-1423] Implement Azure Ultra Disk (UltraSSD) support #13
Conversation
pkg/cloud/azure/services/virtualmachines/virtualmachines_test.go
Outdated
Show resolved
Hide resolved
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
Hold until we've settled on the const naming. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
1 similar comment
|
/retest-required |
damdo
force-pushed
the
ultradisks
branch
2 times, most recently
from
eaebfc5 to
de4234a
Compare
|
/test unit |
|
/retest-required |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest |
|
/retest |
|
Hold until we confirm the desired behaviour on instance deletion. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest-required |
|
Following recent discussions, the data disk deletion logic has been removed from the PR. And will be tracked and handled separately. |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@damdo: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
This PR is part of the overall work (described in this enhancement) for adding Azure Ultra Disk (UltraSSD) support in Machine API for Azure.
In particular it implements:
The Webhook validation for these features is implemented at: openshift/machine-api-operator#1001
while api changes are implemented at: openshift/api#1119