Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OCPCLOUD-1422] machine-api: azureprovider: add ultra disk support #1119

Merged
merged 11 commits into from
Mar 10, 2022
Merged

[OCPCLOUD-1422] machine-api: azureprovider: add ultra disk support #1119

merged 11 commits into from
Mar 10, 2022

Conversation

damdo
Copy link
Member

@damdo damdo commented Feb 11, 2022

This PR implements the API changes described in openshift/enhancements#1021

It adds options to allow the use of Ultra Disks (a.k.a. UltraSSDs) within Azure with Machine API.

Users will be able to use Ultra Disks in two ways:

  • attach them as Data Disks to the Machine
  • attach and mount them via Persistent Volumes (PVs) to the Machine

This enhancement is targeted for OCP 4.11.

@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch from 9615017 to b7bafa5 Compare February 11, 2022 12:39
@damdo damdo marked this pull request as draft February 11, 2022 12:42
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch from b7bafa5 to 17d1cba Compare February 11, 2022 13:26
@damdo damdo marked this pull request as ready for review February 11, 2022 13:31
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2022
@openshift-ci openshift-ci bot requested a review from JoelSpeed February 11, 2022 13:31
@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch from 17d1cba to 029ed23 Compare February 11, 2022 14:06
@JoelSpeed JoelSpeed mentioned this pull request Mar 3, 2022
Closed
@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch 2 times, most recently from ef5f10c to 3c2535f Compare March 8, 2022 12:16
@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch from bfab940 to 1b983ea Compare March 10, 2022 13:44
@damdo damdo force-pushed the machine-api-azureprovider-add-ultra-disk branch from f7ac1d3 to b696301 Compare March 10, 2022 15:34
@JoelSpeed
Copy link
Contributor

Thanks for the updates and additional research into why we need the LUN

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 10, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

@damdo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

deads2k
deads2k reviewed Mar 10, 2022
View reviewed changes
machine/v1beta1/types_azureprovider.go
//
// When set to "Disabled", UltraSSDs will not be allowed either as Data Disks nor as Persistent Volumes.
// In this case if any UltraSSDs are specified as Data Disks on a Machine, the Machine will go into a "Failed" state.
// If instead any UltraSSDs are backing the volumes (via Persistent Volumes) of any Pods scheduled on a Node which is backed by the Machine, the Pod may get stuck in `ContainerCreating` phase.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking note that it would be really good to be able to alert on this condition, since a user cannot fix it themselves.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds, good! Thanks for your help and suggestions.

@deads2k
Copy link
Contributor

deads2k commented Mar 10, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 10, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, deads2k, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@JoelSpeed
Copy link
Contributor

This project is not a part of the no-ff process, as such QE, PX and Docs labels need to be added manually

/label px-approved
/label qe-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Mar 10, 2022
@openshift-merge-robot openshift-merge-robot merged commit abf6417 into openshift:master Mar 10, 2022
@damdo damdo mentioned this pull request Mar 14, 2022
Merged
@damdo
Copy link
Member Author

damdo commented Mar 14, 2022

API design and further changes discussed here are now being ported back to the enhancement initially introduced here: openshift/enhancements#1021 with openshift/enhancements#1060.

jstuever added a commit to jstuever/openshift-installer that referenced this pull request Mar 16, 2022
@jstuever
azure: update variable for machine api compatability
b5ad3f7 
The ManagedDiskParameters variable was renamed in a recent change to the
machine api. This change updates the variable usage to match the new
name: OSDiskManagedDiskParameters.

openshift/api#1119
This was referenced Mar 17, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuever jstuever jstuever left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k deads2k left review comments

@alexander-demicev alexander-demicev Awaiting requested review from alexander-demicev

@mandre mandre Awaiting requested review from mandre

Assignees

@JoelSpeed JoelSpeed

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@damdo @JoelSpeed @deads2k @jstuever @openshift-merge-robot